Fixed issue when multiple sims are performed for models including FFD #3995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chria : Thanks for catching this, I will also apply it to the maintenance branches. |
This was referenced Sep 12, 2024
|
Great! Thanks @mwetter |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If multiple simulations are performed for a model that includes FFD without fully releasing the library, then the second simulation would fail due to that the global structure "cosim" has not been set to NULL in the destructor. The use case can be for instance when the model is compiled into an FMU and the following is performed:
An example model is Buildings.ThermalZones.Detailed.Examples.FFD.ForcedConvection)
Setting the structure "cosim" to NULL will resolve the issue.