Use a callback to to call _reaper instead of scheduling it
#45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asyncio is only maintaining weak references to task. To avoid them being destroyed while still pending, we need to keep a reference on them. Previously, a function was scheduled at each tick to cleanup done tasks. Instead, we add a callback to the task to cleanup its own reference when done. Fix ldo#44.
|
Dang. Wouldn’t you know Patch applied, and thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
asyncio is only maintaining weak references to task. To avoid them
being destroyed while still pending, we need to keep a reference on
them. Previously, a function was scheduled at each tick to cleanup
done tasks. Instead, we add a callback to the task to cleanup its own
reference when done.
Fix #44.