Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup wizard: Responsive language list #11923

Closed
AlexVelezLl opened this issue Feb 26, 2024 · 2 comments · Fixed by #11977
Closed

Setup wizard: Responsive language list #11923

AlexVelezLl opened this issue Feb 26, 2024 · 2 comments · Fixed by #11977
Assignees

Comments

@AlexVelezLl
Copy link
Member

AlexVelezLl commented Feb 26, 2024

Observed behavior

We want the list of languages shown in the LanguageSwitcherList to fit on a single line.

Currently the list of languages in the LanguageSwitcherList is not fully responsive as it relies on window breakpoints to choose the number of languages to be displayed in the list before the "see more". The problem is that this number is fixed and does not depend on the width of the text, and in languages where the text takes up more space, the list items end on a second line. See #11847 (comment).

Expected behavior

The list of languages along with the "see more" fits on a single line in the setup wizard

Steps to reproduce

See #11847 (comment)

Notes

We will need to use here the new KDS component that handles horizontal lists with overflow learningequality/kolibri-design-system#556, so this issue is blocked until that component is implemented.

@nikkuAg
Copy link
Contributor

nikkuAg commented Mar 1, 2024

Is this issue still open? I would like to work on this

@AlexVelezLl
Copy link
Member Author

Hi @nikkuAg! Unfortunately this issue is still blocked until learningequality/kolibri-design-system#552 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants