Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse error in less-1.6.0.js - (Use of JavaScript reserved word) #1772

Closed
matthew-dean opened this issue Jan 2, 2014 · 2 comments
Closed

Comments

@matthew-dean
Copy link
Member

Both Adobe AIR and Eclipse throw a parse error on line 2664 of less-1.6.0.js -

    tf.default = f.eval.bind(f);

Eclipse says "Unexpected token: default".

My assumption is that this is because we've used an illegal reserved word. See:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Reserved_Words

This fixes the problem:

tf["default"] = f.eval.bind(f);

Some JavaScript parsers allow reserved words, but they should never be used because of stricter parsing systems.

@lukeapage
Copy link
Member

fixed by your pull request, now merged.

@matthew-dean let me know when you have finished your integration work (e.g. unlikely to find any more issues like this) and I will release a 1.6.1 bugfix release.

@matthew-dean
Copy link
Member Author

These were the only two (known) issues for me preventing Crunch integration. We have a working beta of our next version based on 1.6.0 (with these 2 fixes), so as far as I know, it's working for me if these are merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants