Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review use of get_children #121

Closed
rianrietveld opened this issue Jun 26, 2018 · 1 comment
Closed

Review use of get_children #121

rianrietveld opened this issue Jun 26, 2018 · 1 comment
Milestone
0.3.3

Comments

@rianrietveld
Copy link
Member

rianrietveld commented Jun 26, 2018 •
edited
Loading

In Clarkson_Object.php the function get_children triggers the VIP warning in the function get_children and get_attachments:

get_children() is discouraged in favor of creating a new WP_Query() so that Advanced Post Cache will cache the query, unless you explicitly supply suppress_filters=> false.

Reconsider the user of get_children here.
@jmslbam jmslbam added this to the 0.4.0 milestone Jun 27, 2018
@rianrietveld
Copy link
Member Author

Discussed this with @NielsdeBlaauw.
The VIP compatibility will be taken out of Clarkson Core and we will create an additional VIP extraction later.
Also because of the VIP(extra) standards will be taken out of the WordPress code standards: (WordPress/WordPress-Coding-Standards#1309 (comment)).

@rianrietveld rianrietveld mentioned this issue Jun 28, 2018
Open
@NielsdeBlaauw NielsdeBlaauw modified the milestones: 0.3.2, 0.3.3 May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
0.3.3
Development

No branches or pull requests
3 participants
@jmslbam @NielsdeBlaauw @rianrietveld