From dbec3b60372e537ff82663dc3c41f4f087a04318 Mon Sep 17 00:00:00 2001 From: Marten Seemann Date: Tue, 6 Jun 2023 15:39:08 +0300 Subject: [PATCH] webrtc: remove incorrect call to ConnectionGater.InterceptAddrDial This function is called from the swarm, not from every individual transport. --- p2p/transport/webrtc/transport.go | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/p2p/transport/webrtc/transport.go b/p2p/transport/webrtc/transport.go index 76c6f700f3..34556f0bf0 100644 --- a/p2p/transport/webrtc/transport.go +++ b/p2p/transport/webrtc/transport.go @@ -231,12 +231,8 @@ func (t *WebRTCTransport) Dial(ctx context.Context, remoteMultiaddr ma.Multiaddr return conn, nil } -func (t *WebRTCTransport) dial( - ctx context.Context, - scope network.ConnManagementScope, - remoteMultiaddr ma.Multiaddr, - p peer.ID, -) (tConn tpt.CapableConn, err error) { +func (t *WebRTCTransport) dial(ctx context.Context, scope network.ConnManagementScope, remoteMultiaddr ma.Multiaddr, p peer.ID) (tConn tpt.CapableConn, err error) { + fmt.Println(remoteMultiaddr) var pc *webrtc.PeerConnection defer func() { if err != nil { @@ -371,11 +367,6 @@ func (t *WebRTCTransport) dial( return nil, err } - // check with the gater if we can dial - if t.gater != nil && !t.gater.InterceptAddrDial(p, remoteMultiaddr) { - return nil, errors.New("not allowed to dial remote peer") - } - // we can only know the remote public key after the noise handshake, // but need to set up the callbacks on the peerconnection conn, err := newConnection(