Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

websocket: accepted connections claim to be WSS even if they are not #2198

Closed
marten-seemann opened this issue Mar 17, 2023 · 0 comments · Fixed by #2199
Closed

websocket: accepted connections claim to be WSS even if they are not #2198

marten-seemann opened this issue Mar 17, 2023 · 0 comments · Fixed by #2199
Labels
kind/bug A bug in existing code (including security flaws)

Comments

@marten-seemann
Copy link
Contributor

Any WebSocket connection will have WSS address, even if we didn't set a tls.Config. They should have a WS address instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug A bug in existing code (including security flaws)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

websocket: don't set a WSS multiaddr for accepted unencrypted conns libp2p/go-libp2p
1 participant
@marten-seemann