Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peerstore interfaces should accept contexts #2231

Closed
guseggert opened this issue Mar 29, 2023 · 1 comment · Fixed by #2312
Closed

Peerstore interfaces should accept contexts #2231

guseggert opened this issue Mar 29, 2023 · 1 comment · Fixed by #2312
Labels
exp/beginner Can be confidently tackled by newcomers help wanted Seeking public contribution on this issue

Comments

@guseggert
Copy link
Contributor

guseggert commented Mar 29, 2023

The peerstore family of interfaces currently don't accept any Go contexts, despite performing IO. This means that, for example, the "pstoreds" package which implements a datastore-backed peerstore can't propagate contexts into the backing datastore. Example:

if err = write.Delete(context.TODO(), key); err == nil {

This means that the datastore can't respect context cancelations and any values stored in the context are also lost (ex. tracing metadata).

@marten-seemann
Copy link
Contributor

Didn't we have a PR for that at some point?

@p-shahi p-shahi added help wanted Seeking public contribution on this issue exp/beginner Can be confidently tackled by newcomers labels May 22, 2023
@marten-seemann marten-seemann linked a pull request Jun 3, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exp/beginner Can be confidently tackled by newcomers help wanted Seeking public contribution on this issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants