Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebRTC UDP Mux: more tests #2536

Closed
MarcoPolo opened this issue Aug 29, 2023 · 0 comments · Fixed by #2586
Closed

WebRTC UDP Mux: more tests #2536

MarcoPolo opened this issue Aug 29, 2023 · 0 comments · Fixed by #2586

Comments

@MarcoPolo
Copy link
Collaborator 

          I'm surprised we only need two tests here. Should we add a test for:
  • A muxed connection will be created before calling the unknown ufrag callback
  • If unknown ufrag callback returns false, then we remove the conn from the muxer map

Originally posted by @MarcoPolo in #2337 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

webrtc: correctly report incoming packet address on muxed connection libp2p/go-libp2p
1 participant
@MarcoPolo