Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close the peerstore #718

Closed
Stebalien opened this issue Sep 6, 2019 · 2 comments
Closed

Close the peerstore #718

Stebalien opened this issue Sep 6, 2019 · 2 comments

Comments

@Stebalien
Copy link
Member

Libp2p doesn't currently close the peerstore, this leaves a GC goroutine hanging around.

On the other hand, I'm not sure if libp2p should close the peerstore if it didn't create it.
@aschmahmann
Copy link
Collaborator

Perhaps a related issue is that the in memory peerstore address book does not take a context, while the datastore based one does.

This combined with the lack of closing a peerstore means that the memory peerstore leaks goroutines.

@aschmahmann aschmahmann mentioned this issue Sep 13, 2019
Closed
@marten-seemann
Copy link
Contributor

Looks like this was fixed by #1037.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Stebalien @marten-seemann @aschmahmann