Skip to content
This repository has been archived by the owner on Jul 21, 2023. It is now read-only.

Commit

Permalink
update to latest multiplex
Browse files Browse the repository at this point in the history
  • Loading branch information
daviddias committed Mar 7, 2016
1 parent feca2c6 commit 7410231
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,6 @@
"mocha": "^2.4.5"
},
"dependencies": {
"multiplex": "github:diasdavid/multiplex#3f15f490ed9244aa4108cebc3177c4aecff92312"
"multiplex": "^6.7.0"
}
}
2 changes: 1 addition & 1 deletion src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ module.exports = function (transport, isListener) {
// muxer.on('close', () => {})
// muxer.on('error', (err) => {})
// muxer.end()
muxer.multicodec = '/multiplex/6.6.1'
muxer.multicodec = '/multiplex/6.7.0'

This comment has been minimized.

Copy link
@hackergrrl

hackergrrl Mar 17, 2016

Contributor

This is an implementation version: shouldn't the multicodec be specifying a protocol version instead? This will be confusing to both parties if a Go multiplexer and a Node multiplexer want to interop.

This comment has been minimized.

Copy link
@daviddias

daviddias Mar 18, 2016

Author Member

It should, unfortunately multiplex doesn't have a spec, so I used the impl version.

return muxer
}

Expand Down

0 comments on commit 7410231

Please sign in to comment.