This repository has been archived by the owner on Feb 24, 2021. It is now read-only.
Async Crypto Endeavour (+benchmarks!) #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Replace lib multihashing with multihashing-async
Using string instead of buffer for proto file
|
There seems to be an issue with go interop on the verification step currently. Investigating currently. |
All good, go interop restored in the latest version. |
daviddias
suggested changes
Oct 5, 2016
| const suite = new Benchmark.Suite('secio') | ||
| const ids = [] | ||
|
|
||
| suite.add('createKey', function (d) { |
There was a problem hiding this comment.
see the other PR or https://benchmarkjs.com/docs
There was a problem hiding this comment.
I mean, can it have a better and intuitive name?
daviddias
approved these changes
Oct 30, 2016
| cb(null, Buffer.concat([ | ||
| data, | ||
| digest | ||
| ])) |
There was a problem hiding this comment.
this could be one line, it is just a Buffer.concat
daviddias
changed the title
|
@diasdavid should be ready |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes all external crypto libraries, except for those used in
libp2p-cryptoandmultihashing. This means it drops the usage of node-forge and relies only on webcrypto in the browser.Needs libp2p/js-libp2p-crypto#10
Stats
Size
1.8M999K606K382KPerformance