This repository has been archived by the owner on Aug 23, 2019. It is now read-only.
fix: revert to try each #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Race was opening multiple connections and not closing/canceling the unused ones. License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
ghost
assigned 
|
This should revert back to https://github.com/libp2p/js-libp2p-switch/blob/ddf622b784de1d3d376f9c429a49a84fbd660ca9/src/limit-dialer/index.js. Currently only the last error will be returned from the limit dialer, whereas https://github.com/libp2p/js-libp2p-switch/blob/ddf622b784de1d3d376f9c429a49a84fbd660ca9/src/limit-dialer/index.js will callback with all errors. This is helpful for diagnosing failed dials because you can see what went wrong with each dial, instead of just the last. |
License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
50 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Race was opening multiple connections and not closing/canceling the unused ones.