This repository has been archived by the owner on Jul 21, 2023. It is now read-only.
fix: update dial function return type to avoid Connection import issue #171
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
index.d.ts
file created during the build process would include an in-line import in thedial
function declaration ofPromise<import("@libp2p/interface-connection/dist/src").Connection>;
../../node_modules/@libp2p/websockets/dist/src/index.d.ts(19,104): error TS2694: Namespace '"@libp2p/interface-connection/dist/src"' has no exported member 'Connection'.
Connection
import explicitly, we avoid the strange in-line import of adist/src
location and I am able to build my project correctly.I believe it is possible that this issue: #163 is also the result of the behavior I was seeing, and this PR may resolve that issue.