Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix example in README #233

Merged
merged 1 commit into from
Aug 13, 2018
Merged

docs: fix example in README #233

merged 1 commit into from
Aug 13, 2018

Conversation

vmx
Copy link
Contributor

@vmx vmx commented Aug 13, 2018

The JSON in the example was missing some commas.

@vmx
docs: fix example in README
f76756c 
The JSON in the example was missing some commas.
@vmx vmx requested a review from jacobheun August 13, 2018 15:02
@ghost ghost assigned vmx Aug 13, 2018
@ghost ghost added the status/in-progress In progress label Aug 13, 2018
jacobheun
jacobheun approved these changes Aug 13, 2018
View reviewed changes
Copy link
Contributor

@jacobheun jacobheun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jacobheun jacobheun merged commit eddec7d into master Aug 13, 2018
@ghost ghost removed the status/in-progress In progress label Aug 13, 2018
@jacobheun jacobheun deleted the fix-readme-example branch August 13, 2018 15:10
maschad pushed a commit to maschad/js-libp2p that referenced this pull request Jun 21, 2023
@achingbrain
fix: yield single buffers (libp2p#233)
31d3938 
* fix: yield single buffers

Messages are serialized to multiple buffers, intsead of yield each
buffer one by one, create single buffers that contain the whole
serialized message. This greatly improves transport performance as
writing one big buffer is a lot faster than writing lots of small
buffers to network sockets etc.

Before:

```
testing 0.40.x-mplex
sender 3276811 messages 17 invocations
sender 6553636 bufs 17 b 24197 ms
105 MB in 32 B chunks in 24170ms
```

After:

```
testing 0.40.x-mplex
sender 3276811 messages 1638408 invocations
1638411 bufs 68 b 8626 ms
105 MB in 32 B chunks in 8611ms
```

* chore: update comment
maschad pushed a commit to maschad/js-libp2p that referenced this pull request Jun 21, 2023
@semantic-release-bot
chore(release): 7.0.5 [skip ci]
9d4dd87 
## [7.0.5](libp2p/js-libp2p-mplex@v7.0.4...v7.0.5) (2022-11-24)

### Bug Fixes

* apply message size limit before decoding message ([libp2p#231](libp2p/js-libp2p-mplex#231)) ([279ad47](libp2p/js-libp2p-mplex@279ad47))
* limit unprocessed message queue size separately to message size ([libp2p#234](libp2p/js-libp2p-mplex#234)) ([2297856](libp2p/js-libp2p-mplex@2297856))
* yield single buffers ([libp2p#233](libp2p/js-libp2p-mplex#233)) ([31d3938](libp2p/js-libp2p-mplex@31d3938))
maschad pushed a commit to maschad/js-libp2p that referenced this pull request Jun 21, 2023
@dependabot
deps(dev): bump sinon from 14.0.2 to 15.0.0 (libp2p#233)
72a79ab 
Bumps [sinon](https://github.com/sinonjs/sinon) from 14.0.2 to 15.0.0.
- [Release notes](https://github.com/sinonjs/sinon/releases)
- [Changelog](https://github.com/sinonjs/sinon/blob/main/docs/changelog.md)
- [Commits](sinonjs/sinon@v14.0.2...v15.0.0)

---
updated-dependencies:
- dependency-name: sinon
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
maschad pushed a commit to maschad/js-libp2p that referenced this pull request Jun 21, 2023
@semantic-release-bot
chore(release): 6.0.5 [skip ci]
1bfc601 
## [6.0.5](libp2p/js-libp2p-tcp@v6.0.4...v6.0.5) (2022-12-06)

### Dependencies

* **dev:** bump sinon from 14.0.2 to 15.0.0 ([libp2p#233](libp2p/js-libp2p-tcp#233)) ([72a79ab](libp2p/js-libp2p-tcp@72a79ab))
maschad pushed a commit to maschad/js-libp2p that referenced this pull request Jun 21, 2023
@dependabot @achingbrain
deps: bump @libp2p/interface-transport from 3.0.0 to 4.0.0 (libp2p#233)
da0367f 
* deps: bump @libp2p/interface-transport from 3.0.0 to 4.0.0

Bumps [@libp2p/interface-transport](https://github.com/libp2p/js-libp2p-interfaces) from 3.0.0 to 4.0.0.
- [Release notes](https://github.com/libp2p/js-libp2p-interfaces/releases)
- [Commits](https://github.com/libp2p/js-libp2p-interfaces/compare/@libp2p/interface-transport-v3.0.0...@libp2p/interface-transport-v4.0.0)

---
updated-dependencies:
- dependency-name: "@libp2p/interface-transport"
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* deps(dev): bump @libp2p/interface-mocks from 10.0.3 to 11.0.0

Bumps [@libp2p/interface-mocks](https://github.com/libp2p/js-libp2p-interfaces) from 10.0.3 to 11.0.0.
- [Release notes](https://github.com/libp2p/js-libp2p-interfaces/releases)
- [Commits](https://github.com/libp2p/js-libp2p-interfaces/compare/@libp2p/interface-mocks-v10.0.3...@libp2p/interface-mocks-v11.0.0)

---
updated-dependencies:
- dependency-name: "@libp2p/interface-mocks"
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* deps(dev): bump @libp2p/interface-transport-compliance-tests

Bumps [@libp2p/interface-transport-compliance-tests](https://github.com/libp2p/js-libp2p-interfaces) from 3.0.13 to 4.0.0.
- [Release notes](https://github.com/libp2p/js-libp2p-interfaces/releases)
- [Commits](https://github.com/libp2p/js-libp2p-interfaces/compare/@libp2p/interface-transport-compliance-tests-v3.0.13...@libp2p/interface-transport-compliance-tests-v4.0.0)

---
updated-dependencies:
- dependency-name: "@libp2p/interface-transport-compliance-tests"
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: achingbrain <alex@achingbrain.net>
maschad pushed a commit to maschad/js-libp2p that referenced this pull request Jun 21, 2023
@semantic-release-bot
chore(release): 6.0.1 [skip ci]
3645c2b 
## [6.0.1](libp2p/js-libp2p-websockets@v6.0.0...v6.0.1) (2023-04-24)

### Dependencies

* bump @libp2p/interface-transport from 3.0.0 to 4.0.0 ([libp2p#233](libp2p/js-libp2p-websockets#233)) ([da0367f](libp2p/js-libp2p-websockets@da0367f))
achingbrain added a commit that referenced this pull request Jun 27, 2023
@dependabot @achingbrain
deps(dev): bump aegir from 38.1.8 to 39.0.10 (#233)
e073298 
* deps(dev): bump aegir from 38.1.8 to 39.0.10

Bumps [aegir](https://github.com/ipfs/aegir) from 38.1.8 to 39.0.10.
- [Release notes](https://github.com/ipfs/aegir/releases)
- [Changelog](https://github.com/ipfs/aegir/blob/master/CHANGELOG.md)
- [Commits](ipfs/aegir@v38.1.8...v39.0.10)

---
updated-dependencies:
- dependency-name: aegir
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* chore: update linting

* chore: add missing dep

* chore: update deps

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: achingbrain <alex@achingbrain.net>
achingbrain pushed a commit that referenced this pull request Jun 27, 2023
@semantic-release-bot
chore(release): 7.0.2 [skip ci]
8ee5c79 
## [7.0.2](libp2p/js-libp2p-floodsub@v7.0.1...v7.0.2) (2023-06-27)

### Trivial Changes

* Update .github/workflows/semantic-pull-request.yml [skip ci] ([3e98edd](libp2p/js-libp2p-floodsub@3e98edd))
* Update .github/workflows/stale.yml [skip ci] ([95c7400](libp2p/js-libp2p-floodsub@95c7400))

### Dependencies

* **dev:** bump aegir from 38.1.8 to 39.0.10 ([#233](libp2p/js-libp2p-floodsub#233)) ([e073298](libp2p/js-libp2p-floodsub@e073298))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobheun jacobheun jacobheun approved these changes

Assignees

@vmx vmx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vmx @jacobheun