Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential unbounded buffer growth in background task of pending connection. #1465

Closed
romanb opened this issue Feb 23, 2020 · 1 comment · Fixed by #1527
Closed

Potential unbounded buffer growth in background task of pending connection. #1465

romanb opened this issue Feb 23, 2020 · 1 comment · Fixed by #1527

Comments

@romanb
Copy link
Contributor

romanb commented Feb 23, 2020

It was brought up in #1440 (comment) that there is a theoretical unbounded growing buffer of pending events for a connection handler in a background Tasks events buffer while the connection is still pending (i.e. being established). While in practice every connection attempt is eventually bound to time out, it may nevertheless be preferable to bound the buffer. My current suggestion would be to add a hard upper limit for the size of the buffer which, when reached, results in the connection attempt to be aborted and the background task dropped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants