You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In #3337, EitherError was replaced with either::Either. This is fine, except that libp2p does not re-export the Either type, and therefore libp2p consumers have to add either to their dependencies. It's a bit of maintenance overhead and a risk of a versioning conflict.
I propose re-exporting the entire either crate from libp2p.
This will also simplify the upgrade path from v0.50 to v0.51.
- use libp2p::core::either::EitherError;+ use libp2p::core::either::Either;
Are you planning to do it yourself in a pull request?
Yes, I am happy to contribute a pull request if we agree this is a change you will accept.
Should we export either as libp2::core::either or libp2p::either?
The text was updated successfully, but these errors were encountered:
Description
In #3337,
EitherError
was replaced witheither::Either
. This is fine, except that libp2p does not re-export theEither
type, and therefore libp2p consumers have to addeither
to their dependencies. It's a bit of maintenance overhead and a risk of a versioning conflict.I propose re-exporting the entire
either
crate fromlibp2p
.This will also simplify the upgrade path from v0.50 to v0.51.
Are you planning to do it yourself in a pull request?
Yes, I am happy to contribute a pull request if we agree this is a change you will accept.
Should we export
either
aslibp2::core::either
orlibp2p::either
?The text was updated successfully, but these errors were encountered: