Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(webrtc): Chrome data-channels not closing #4333

Open
Marcel-G opened this issue Aug 16, 2023 · 1 comment
Open

bug(webrtc): Chrome data-channels not closing #4333

Marcel-G opened this issue Aug 16, 2023 · 1 comment

Comments

@Marcel-G
Copy link
Contributor

Summary

When connecting a js-libp2p (browser) peer and rust-libp2p peer via webrtc, data channels are no properly closing.
The first reason for that is js-libp2p never closes them to begin with. That is being addressed here: libp2p/js-libp2p#1976

The next issue is that the rust-libp2p WebRTC implementation webrtc-rs doesn't properly respond to the browsers stream reset, leaving the browser in a closing state.

And in case of switching to str0m #3659, it also has the same issue:

Possible Solution

I am opening this issue for visibility, and to possibly get some support with the PR reviews on these repositories.
This can be closed when bumping the dependency version.

Would you like to work on fixing this bug?

Yes

@mxinden
Copy link
Member

mxinden commented Aug 16, 2023

Much appreciate the thorough work @Marcel-G. Thank you.

I subscribed to the relevant open issues and pull requests. Please ping me on those in case I can be helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants