Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a crate that provides a test suit for an implementation of StreamMuxer #508

Closed
tomaka opened this issue Sep 21, 2018 · 2 comments · Fixed by #2952
Closed

Add a crate that provides a test suit for an implementation of StreamMuxer #508

tomaka opened this issue Sep 21, 2018 · 2 comments · Fixed by #2952
Labels
difficulty:easy difficulty:moderate getting-started Issues that can be tackled if you don't know the internals of libp2p very well priority:important The changes needed are critical for libp2p, or are blocking another project

Comments

@tomaka
Copy link
Member

tomaka commented Sep 21, 2018

Add a crate that provides:

pub fn test_muxer<T: StreamMuxer>(muxer: T) { ... }

Of course the implementation would check whether the muxer behaves as expected.

Then mplex, yamux and future implementations could import that crate and run the function.

@tomaka tomaka added priority:important The changes needed are critical for libp2p, or are blocking another project difficulty:easy difficulty:moderate labels Sep 21, 2018
@tomaka
Copy link
Member Author

tomaka commented Sep 21, 2018

We should do #493 first

@tomaka
Copy link
Member Author

tomaka commented Sep 28, 2018

cc @dvdplm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty:easy difficulty:moderate getting-started Issues that can be tackled if you don't know the internals of libp2p very well priority:important The changes needed are critical for libp2p, or are blocking another project
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants