Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable browser webrtc tests #237

Closed
wants to merge 1 commit into from
Closed

Disable browser webrtc tests #237

wants to merge 1 commit into from

Conversation

MarcoPolo
Copy link
Contributor

#235 These have been giving us a lot of false negatives. Let's disable them until we investigate why they are so flaky.

mxinden
mxinden approved these changes Jul 16, 2023
View reviewed changes
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am a bit afraid of a regression while these are disabled. That said, I don't feel strongly about it. I am fine merging here.

@p-shahi
Copy link
Member

p-shahi commented Aug 7, 2023

Should this be merged or kept open while #235 is being investigated?

@p-shahi
Copy link
Member

p-shahi commented Aug 18, 2023

closing in favor of #265

@p-shahi p-shahi closed this Aug 18, 2023
@p-shahi p-shahi deleted the marco/disable-webrtc branch August 18, 2023 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxinden mxinden mxinden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MarcoPolo @p-shahi @mxinden