DO NOT MERGE: testing webrtc using multidim stack #240
Conversation
maschad
changed the title
maschad
changed the title
|
I don't understand why we're copying so much of the multidim-interop test runner code. Shouldn't this be able to live inside |
| const connectButton = page.getByTestId('connectButton'); | ||
| const messageInputBox = page.getByTestId('message'); | ||
| const sendButton = page.getByTestId('sendButton'); | ||
| const receivedBox = page.getByTestId('receivebox'); |
There was a problem hiding this comment.
I don't understand. Are these referencing the same page? Are you not testing communication between two browsers?
There was a problem hiding this comment.
If the intention is to set up an RTCDataChannel between two browsers via playwright, wouldn't that essentially be a simplistic replication of the test here?
There was a problem hiding this comment.
Yes, that's the goal. Except without any js-libp2p. From the original issue:
Maybe a very simple non-js-libp2p browser only interop test would be a good way to test if the browser is at fault.
There was a problem hiding this comment.
I understand, but upon reconsideration I wondering what insights that may yield given this test passes consistently. Do you think it would be fruitful to run that test in the multidim interop setup?
There was a problem hiding this comment.
Does that test run with multiple browsers? Looking at it, it seems like it's run within a single context. By multiple browsers, I mean browser A connects to browser B over webrtc.
There was a problem hiding this comment.
Gotcha, you are correct it does not run in multiple browsers.
Related #235