Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(js-libp2p): re-introduce /webrtc transport interop tests #310

Merged
merged 2 commits into from
Nov 15, 2023

Conversation

maschad
Copy link
Member

@maschad maschad commented Oct 10, 2023

Depends on #305

Given the bug fixes introduced in libp2p/js-libp2p#2073 to reliably close streams we should more stable tests.

Closes #235
Closes libp2p/js-libp2p#1846

Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Let's see what CI says :)

@thomaseizinger thomaseizinger changed the title feat: re-introduce webRTC tests feat(js-libp2p): re-introduce webRTC tests Oct 10, 2023
@thomaseizinger thomaseizinger changed the title feat(js-libp2p): re-introduce webRTC tests feat(js-libp2p): re-introduce /webrtc tests Oct 10, 2023
@thomaseizinger thomaseizinger changed the title feat(js-libp2p): re-introduce /webrtc tests feat(js-libp2p): re-introduce /webrtc transport interop tests Oct 10, 2023
@maschad
Copy link
Member Author

maschad commented Oct 10, 2023

Unfortunately CI probably won't pass as I need to upgrade js-libp2p first

@thomaseizinger thomaseizinger merged commit b9aa2a5 into libp2p:master Nov 15, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

js-libp2p webrtc tests flaky test: Investigate inconsistent webRTC Interop Tests
2 participants