Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[x86] Noise in arcade games #4359

Closed
sergiobenrocha2 opened this issue Jan 4, 2017 · 11 comments
Closed

[x86] Noise in arcade games #4359

sergiobenrocha2 opened this issue Jan 4, 2017 · 11 comments

Comments

@sergiobenrocha2
Copy link
Contributor

sergiobenrocha2 commented Jan 4, 2017

I can hear a noise when playing arcade games (tested cps-2 and neo geo so far), using MAME 2014 and FBA on Linux 32-bit only (xubuntu 14.04, running on VM, alsa or pulse drivers).

It does not happen with MAME 2010 and old FBA 2012 cores.

@sergiobenrocha2
Copy link
Contributor Author

Weird, using goldnaxe, I can hear the noise in FBA, but not in MAME 2014

@andres-asm
Copy link
Contributor

I don't see how this could be a RetroArch problem

@andres-asm
Copy link
Contributor

Could be an issue with the cores. In any case it needs more information.
It's hard to tell what's a bug without any references

@sergiobenrocha2
Copy link
Contributor Author

sergiobenrocha2 commented Mar 17, 2017

Yeah, it's really a core issue heh

Reverting this:

#define AUDIO_SAMPLERATE 48000
#define AUDIO_SEGMENT_LENGTH 801 // <-- Hardcoded value that corresponds well to 48kHz audio.

To this:

#define AUDIO_SAMPLERATE 32000
#define AUDIO_SEGMENT_LENGTH 534 // <-- Hardcoded value that corresponds well to 32kHz audio.

in the libretro.cpp fix the issue in FB Alpha. @barbudreadmon any idea why does it happen only on i386?

@sergiobenrocha2
Copy link
Contributor Author

sergiobenrocha2 commented Mar 17, 2017

It's not happening on xubuntu 16.04 (FBA or MAME 2014), only in 14.04. I made the tests using 14.04 in a real machine, same issue, so it's not related to VM. Maybe it's related to a system thing...?

@barbudreadmon
Copy link
Contributor

There was a report a few months ago. It seems to depend on the system you use. Those values need to be converted to core options.

@ghost
Copy link

ghost commented Mar 17, 2017

since 48000hz seems to be max supported by retroarch, is it possible that this is some sort of headroom issue?

https://github.com/libretro/fbalpha/blob/master/src/burner/libretro/libretro.cpp#L1475

this should probably work too, with at least higher sampling rate and a bit of headroom.
#define AUDIO_SAMPLERATE 44100
#define AUDIO_SEGMENT_LENGTH 740// <-- Hardcoded value that corresponds well to 44.1kHz audio.

@sergiobenrocha2
Copy link
Contributor Author

sergiobenrocha2 commented Mar 17, 2017

I tried that, same issue if you modify retroarch audio_out_rate from 48 to 44.1 kHz

Actually, the issue will appear if you have same sample rate value for both retroarch and FBA (tried with 32 kHz as well)

@barbudreadmon
Copy link
Contributor

Those changes followed a discussion with dink a few months ago, you can check the discussion there : http://neosource.1emulation.com/forums/index.php?topic=2487.msg22799#msg22799 , perhaps it will help.

@ghost
Copy link

ghost commented Mar 17, 2017

Just FYI I have been told that changing audio_out_rate away from 48khz is a "bad idea" and that it can cause strange problems.

@sergiobenrocha2
Copy link
Contributor Author

Just a heads up, recalbox users are getting this issue too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants