Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase/document guarantees around DiscardFunding event #2508

Open
wvanlint opened this issue Aug 17, 2023 · 1 comment
Open

Increase/document guarantees around DiscardFunding event #2508

wvanlint opened this issue Aug 17, 2023 · 1 comment
Milestone

Comments

@wvanlint
Copy link
Contributor

wvanlint commented Aug 17, 2023

Currently, channels with unbroadcasted funding transactions that are closed/lost on restart do not generate DiscardFunding events. One case where we are able to detect this is here.

However, persistence would also need to change to provide increased guarantees, as Channels and ChannelMonitors are only persisted at funding_signed instead of funding_created and the asynchronous persistence of Channels is not guaranteed at any point. For the latter, see also #2505.

@TheBlueMatt
Copy link
Collaborator

Tagging 0.1 at least until we document this, then we should fix it later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants