multi: allow min-depth of zero for non-zero conf channels #8796

ellemouton · 2024-05-30T20:31:02Z

If our peer indicates to us that they are OK with a zero conf channel (ie, they trust us) by setting min-depth to 0 in accept_channel, then as long as they support SCID aliases, we should just upgrade the channel to ZeroConf and continue the funding flow.

EDIT: updated to just allow the peer to set min-depth to 0. We dont upgrade the channel type.

Fixes #8783

NOTE: we already allow ourselves to do this when our peer sends us an OpenChannel without a zero-conf channel type:

lnd/funding/manager.go

Lines 1570 to 1583 in fed7609

    
           if !zeroConf && acceptorResp.ZeroConf { 
        
           	if !scidFeatureVal { 
        
           		// Fail the funding flow. 
        
           		flowErr := fmt.Errorf("scid-alias feature " + 
        
           			"must be negotiated for zero-conf") 
        
           		log.Errorf("Cancelling funding flow for "+ 
        
           			"zero-conf channel %v: %v", cid, 
        
           			flowErr) 
        
           		f.failFundingFlow(peer, cid, flowErr) 
        
           		return 
        
           	} 
        
           	// Set zeroConf to true to enable the zero-conf flow. 
        
           	zeroConf = true

So all this PR does is allow our peer to do this too :)

coderabbitai · 2024-05-30T20:31:08Z

Important

Review skipped

Auto reviews are limited to specific labels.

Labels to auto review (1)

llm-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

channeldb/channel.go

Crypt-iQ · 2024-05-31T19:03:19Z

funding/manager.go

+
+		// Zero conf channels will require an SCID alias, so request one
+		// now and add it to the reservation.
+		aliasScid, err := f.cfg.AliasManager.RequestAlias()


ellemouton · 2024-06-07T16:00:47Z

hmmm ok from this comment on the original issue, it sounds like we dont actually need to go and change this to a zero conf channel. We can just allow them to send a min-depth of 0 (even though this is not a zero conf channel) and then we just continue as normal (and only send channel_ready when we see fit).

so the diff can actually be way smaller

cc @Crypt-iQ - wdyt?

Crypt-iQ · 2024-06-11T17:39:12Z

hmmm ok from this comment on the original issue, it sounds like we dont actually need to go and change this to a zero conf channel. We can just allow them to send a min-depth of 0 (even though this is not a zero conf channel) and then we just continue as normal (and only send channel_ready when we see fit).

so the diff can actually be way smaller

cc @Crypt-iQ - wdyt?

yup that seems fine

ellemouton · 2024-06-13T18:31:54Z

Ok I've made the update discussed above.

It's hard to write a test for this case cause we dont really support this between two LND nodes opening a non-zero conf channel cause we want to register for confirmations and this is not allowed with a depth of 0.

So to test this you can apply this patch which allows our channel acceptor to set a MinDepth of 0 & also makes sure we still register for 1 conf if we are on the receiver side of this operation. Then to actually test the flow, you can run the scid_alias_channel_update/public_no-chan-type_update test which uses the channel acceptor to open a non zero conf channel

lightninglabs-deploy · 2024-06-20T18:48:12Z

@Crypt-iQ: review reminder

yyforyongyu

Needs a rebase, otherwise LGTM🌊

Even if the channel type is not zero conf. We will still use a min depth of at least 1. We just dont fail if our peer indicates trust.

ellemouton force-pushed the acceptImplicitZeroConf branch from f007b18 to 0ddcb39 Compare May 30, 2024 20:36

ellemouton commented May 30, 2024

View reviewed changes

channeldb/channel.go Outdated Show resolved Hide resolved

ellemouton requested a review from Crypt-iQ May 30, 2024 20:56

Crypt-iQ reviewed May 31, 2024

View reviewed changes

saubyk assigned ellemouton Jun 3, 2024

saubyk added the zero conf label Jun 3, 2024

saubyk added this to the v0.18.1 milestone Jun 3, 2024

ellemouton force-pushed the acceptImplicitZeroConf branch from 0ddcb39 to fcb4382 Compare June 13, 2024 18:28

ellemouton changed the title ~~multi: allow implicit zero conf channels~~ multi: allow min-depth of zero for non-zero conf channels Jun 14, 2024

ellemouton requested a review from Crypt-iQ June 14, 2024 20:03

ellemouton force-pushed the acceptImplicitZeroConf branch from 2f08f20 to c64ba9d Compare June 18, 2024 23:19

saubyk added the P2 should be fixed if one has time label Jun 25, 2024

yyforyongyu approved these changes Jun 25, 2024

View reviewed changes

Crypt-iQ approved these changes Jun 25, 2024

View reviewed changes

ellemouton added 2 commits June 27, 2024 15:26

funding: allow AcceptChannel with min depth of zero

1c65c3d

Even if the channel type is not zero conf. We will still use a min depth of at least 1. We just dont fail if our peer indicates trust.

docs: add release notes entry

9d1320a

ellemouton force-pushed the acceptImplicitZeroConf branch from c64ba9d to 9d1320a Compare June 27, 2024 22:27

ellemouton merged commit 71ba355 into lightningnetwork:master Jun 28, 2024
30 of 34 checks passed

ellemouton deleted the acceptImplicitZeroConf branch June 28, 2024 14:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

multi: allow min-depth of zero for non-zero conf channels #8796

multi: allow min-depth of zero for non-zero conf channels #8796

ellemouton commented May 30, 2024 •

edited

Loading

coderabbitai bot commented May 30, 2024 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

Crypt-iQ May 31, 2024

ellemouton commented Jun 7, 2024

Crypt-iQ commented Jun 11, 2024

ellemouton commented Jun 13, 2024

lightninglabs-deploy commented Jun 20, 2024

yyforyongyu left a comment

	if !zeroConf && acceptorResp.ZeroConf {
	if !scidFeatureVal {
	// Fail the funding flow.
	flowErr := fmt.Errorf("scid-alias feature " +
	"must be negotiated for zero-conf")
	log.Errorf("Cancelling funding flow for "+
	"zero-conf channel %v: %v", cid,
	flowErr)
	f.failFundingFlow(peer, cid, flowErr)
	return
	}

	// Set zeroConf to true to enable the zero-conf flow.
	zeroConf = true

multi: allow min-depth of zero for non-zero conf channels #8796

multi: allow min-depth of zero for non-zero conf channels #8796

Conversation

ellemouton commented May 30, 2024 • edited Loading

coderabbitai bot commented May 30, 2024 • edited Loading

Review skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

Crypt-iQ May 31, 2024

Choose a reason for hiding this comment

ellemouton commented Jun 7, 2024

Crypt-iQ commented Jun 11, 2024

ellemouton commented Jun 13, 2024

lightninglabs-deploy commented Jun 20, 2024

yyforyongyu left a comment

Choose a reason for hiding this comment

ellemouton commented May 30, 2024 •

edited

Loading

coderabbitai bot commented May 30, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)