[TAS-1217] 🚸 Add default value to stakeholders #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
AuroraHuang22
commented
Feb 15, 2024
AuroraHuang22
commented
AuroraHuang22
added a commit
that referenced
this pull request
Feb 15, 2024
williamchong
requested changes
Feb 15, 2024
components/IscnRegisterForm.vue
Outdated
Comment on lines
1135
to
1137
| const { data } = await this.$axios.get( | ||
| getUserInfoMinByAddress(this.address), | ||
| ) |
There was a problem hiding this comment.
Will this throw 404 error, skipping the whole iscnOwner block if the address does not have likeId?
There was a problem hiding this comment.
AuroraHuang22
added a commit
that referenced
this pull request
Feb 16, 2024
williamchong
requested changes
Feb 16, 2024
components/IscnRegisterForm.vue
Outdated
Comment on lines
1143
to
1162
| try { | ||
| const { data } = await this.$axios.get(getUserInfoMinByAddress(address)) | ||
| return { | ||
| name: data?.displayName || address, | ||
| wallet: [{ content: address, id: 1, type: 'like', isOpenOptions: false }], | ||
| url: [], | ||
| likerId: data?.user || '', | ||
| authorDescription: data?.description || 'Publisher', | ||
| } | ||
| } catch (error) { | ||
| // eslint-disable-next-line no-console | ||
| console.error(error) | ||
| return { | ||
| name: address, | ||
| wallet: [{ content: address, id: 1, type: 'like', isOpenOptions: false }], | ||
| url: [], | ||
| likerId: '', | ||
| authorDescription: 'Publisher', | ||
| } | ||
| } |
There was a problem hiding this comment.
Suggested change
| try { | |
| const { data } = await this.$axios.get(getUserInfoMinByAddress(address)) | |
| return { | |
| name: data?.displayName || address, | |
| wallet: [{ content: address, id: 1, type: 'like', isOpenOptions: false }], | |
| url: [], | |
| likerId: data?.user || '', | |
| authorDescription: data?.description || 'Publisher', | |
| } | |
| } catch (error) { | |
| // eslint-disable-next-line no-console | |
| console.error(error) | |
| return { | |
| name: address, | |
| wallet: [{ content: address, id: 1, type: 'like', isOpenOptions: false }], | |
| url: [], | |
| likerId: '', | |
| authorDescription: 'Publisher', | |
| } | |
| } | |
| let userData: any = null; | |
| try { | |
| ({ data: userData } = await this.$axios.get(getUserInfoMinByAddress(address))) | |
| } catch (error) { | |
| // eslint-disable-next-line no-console | |
| console.error(error) | |
| } | |
| return { | |
| name: userData?.displayName || address, | |
| wallet: [{ content: address, id: 1, type: 'like', isOpenOptions: false }], | |
| url: [], | |
| likerId: userData?.user || '', | |
| authorDescription: userData?.description || 'Publisher', | |
| } |
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.