Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🩹 Fix event list table duplicated keys #808

Merged
merged 2 commits into from
Nov 28, 2022

Conversation

nwingt
Copy link
Member

@nwingt nwingt commented Nov 26, 2022

No description provided.

Copy link
Member

@williamchong williamchong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want class id if we are adding nftid anyway

@nwingt
Copy link
Member Author

nwingt commented Nov 26, 2022

But the events of this page is under the same NFT Class, so it makes no different?

@williamchong
Copy link
Member

But the events of this page is under the same NFT Class, so it makes no different?

Not for now, depends if you think this component would be used in some cross class id scenerio

@nwingt nwingt force-pushed the fix/duplicated-event-list-keys branch from 607922d to 48d72d9 Compare November 26, 2022 13:55
@nwingt nwingt merged commit 3e39515 into likecoin:develop Nov 28, 2022
@nwingt nwingt deleted the fix/duplicated-event-list-keys branch November 28, 2022 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants