Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): update tonic, prost, and linkerd2-proxy-api #1137

Merged
merged 3 commits into from
Jul 9, 2021

Conversation

hawkw
Copy link
Member

@hawkw hawkw commented Jul 8, 2021

This updates prost, prost-types, and prost-build to v0.8, which
includes a fix for a panic (and potential denial-of-service attack) when
converting a protobuf duration into a Rust Duration. Although we don't
use the vulnerable APIs in the proxy or in linkerd2-proxy-api, this is
necessary in order to fix a RUSTSEC advisory warning. In order to update
prost, we must also update tonic and tonic-build to v0.5, which
depends on prost 0.8, and update the linkerd2-proxy-api crate to
include linkerd/linkerd2-proxy-api#71.

Since these crates all depend on each other, we need to update them all
at the same time. Dependabot has opened separate PRs for these crates,
but none of them will pass CI, since they depend on incompatible
versions. This PR, on the other hand, should pass, since it updates all
the crates atomically in one commit. Also, some minor code changes
were required due to breaking API changes in tonic 0.5.

Closes #1134, #1135, and #1136; should fix CI.

hawkw added 2 commits July 8, 2021 15:36
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
@hawkw hawkw requested review from olix0r and a team July 8, 2021 22:41
@olix0r olix0r merged commit e908293 into main Jul 9, 2021
@olix0r olix0r deleted the eliza/prost-0.8 branch July 9, 2021 14:53
olix0r added a commit to linkerd/linkerd2 that referenced this pull request Jul 15, 2021
This release replaces the `request_errors_total` metric with new metrics:
`inbound_http_errors_total` and `outbound_http_errors_total`. This
release also introduces new metrics--`inbound_tcp_accept_errors_total`
and `outbound_tcp_accept_errors_total`--that count proxy errors
encountered before a protocol can be detected.

---

* build(deps): Remove version comments from Actions (linkerd/linkerd2-proxy#1109)
* build(deps): bump mimalloc from 0.1.25 to 0.1.26 (linkerd/linkerd2-proxy#1110)
* build(deps): bump trust-dns-resolver from `ed9f05b` to `57b131f` (linkerd/linkerd2-proxy#1111)
* build(deps): bump tokio from 1.7.0 to 1.7.1 (linkerd/linkerd2-proxy#1113)
* build(deps): bump drain from 0.0.1 to 0.1.0 (linkerd/linkerd2-proxy#1112)
* build(deps): bump tracing-subscriber from 0.2.18 to 0.2.19 (linkerd/linkerd2-proxy#1116)
* build(deps): bump indexmap from 1.6.2 to 1.7.0 (linkerd/linkerd2-proxy#1120)
* build(deps): bump trust-dns-resolver from `57b131f` to `be0324a` (linkerd/linkerd2-proxy#1121)
* docs: Fix some compile errors that occur in `cargo doc` (linkerd/linkerd2-proxy#1115)
* build(deps): bump trust-dns-resolver from `be0324a` to `9048a39` (linkerd/linkerd2-proxy#1125)
* build(deps): bump tokio from 1.7.1 to 1.8.0 (linkerd/linkerd2-proxy#1126)
* build(deps): bump thiserror from 1.0.25 to 1.0.26 (linkerd/linkerd2-proxy#1127)
* build(deps): bump linkerd2-proxy-api from `48f13d6` to `def4e32` (linkerd/linkerd2-proxy#1128)
* tls: always use `tokio-rustls` re-export of `rustls` (linkerd/linkerd2-proxy#1122)
* build(deps): bump libc from 0.2.97 to 0.2.98 (linkerd/linkerd2-proxy#1129)
* build(deps): bump tokio from 1.8.0 to 1.8.1 (linkerd/linkerd2-proxy#1130)
* build(deps): bump tokio-stream from 0.1.6 to 0.1.7 (linkerd/linkerd2-proxy#1131)
* build(deps): bump hyper from 0.14.9 to 0.14.10 (linkerd/linkerd2-proxy#1132)
* Replace the `request_error_total` metric (linkerd/linkerd2-proxy#1133)
* build(deps): update `tonic`, `prost`, and  `linkerd2-proxy-api` (linkerd/linkerd2-proxy#1137)
* inbound: add `inbound_tls_detect_error_total` metric (linkerd/linkerd2-proxy#1114)
* build(deps): bump trust-dns-resolver from `9048a39` to `9b46575` (linkerd/linkerd2-proxy#1139)
* build(deps): bump trust-dns-resolver from `9b46575` to `af83717` (linkerd/linkerd2-proxy#1140)
* metrics: Use `parking_lot::Mutex` in telemetry (linkerd/linkerd2-proxy#1142)
* metrics: factor out `NewService` for target-scoped metrics (linkerd/linkerd2-proxy#1117)
* build(deps): bump linkerd2-proxy-api from `5e4e190` to `e03dfe4` (linkerd/linkerd2-proxy#1143)
* build(deps): bump tonic-build from 0.5.0 to 0.5.1 (linkerd/linkerd2-proxy#1141)
kleimkuhler pushed a commit to linkerd/linkerd2 that referenced this pull request Jul 15, 2021
This release replaces the `request_errors_total` metric with new metrics:
`inbound_http_errors_total` and `outbound_http_errors_total`. This
release also introduces new metrics--`inbound_tcp_accept_errors_total`
and `outbound_tcp_accept_errors_total`--that count proxy errors
encountered before a protocol can be detected.

---

* build(deps): Remove version comments from Actions (linkerd/linkerd2-proxy#1109)
* build(deps): bump mimalloc from 0.1.25 to 0.1.26 (linkerd/linkerd2-proxy#1110)
* build(deps): bump trust-dns-resolver from `ed9f05b` to `57b131f` (linkerd/linkerd2-proxy#1111)
* build(deps): bump tokio from 1.7.0 to 1.7.1 (linkerd/linkerd2-proxy#1113)
* build(deps): bump drain from 0.0.1 to 0.1.0 (linkerd/linkerd2-proxy#1112)
* build(deps): bump tracing-subscriber from 0.2.18 to 0.2.19 (linkerd/linkerd2-proxy#1116)
* build(deps): bump indexmap from 1.6.2 to 1.7.0 (linkerd/linkerd2-proxy#1120)
* build(deps): bump trust-dns-resolver from `57b131f` to `be0324a` (linkerd/linkerd2-proxy#1121)
* docs: Fix some compile errors that occur in `cargo doc` (linkerd/linkerd2-proxy#1115)
* build(deps): bump trust-dns-resolver from `be0324a` to `9048a39` (linkerd/linkerd2-proxy#1125)
* build(deps): bump tokio from 1.7.1 to 1.8.0 (linkerd/linkerd2-proxy#1126)
* build(deps): bump thiserror from 1.0.25 to 1.0.26 (linkerd/linkerd2-proxy#1127)
* build(deps): bump linkerd2-proxy-api from `48f13d6` to `def4e32` (linkerd/linkerd2-proxy#1128)
* tls: always use `tokio-rustls` re-export of `rustls` (linkerd/linkerd2-proxy#1122)
* build(deps): bump libc from 0.2.97 to 0.2.98 (linkerd/linkerd2-proxy#1129)
* build(deps): bump tokio from 1.8.0 to 1.8.1 (linkerd/linkerd2-proxy#1130)
* build(deps): bump tokio-stream from 0.1.6 to 0.1.7 (linkerd/linkerd2-proxy#1131)
* build(deps): bump hyper from 0.14.9 to 0.14.10 (linkerd/linkerd2-proxy#1132)
* Replace the `request_error_total` metric (linkerd/linkerd2-proxy#1133)
* build(deps): update `tonic`, `prost`, and  `linkerd2-proxy-api` (linkerd/linkerd2-proxy#1137)
* inbound: add `inbound_tls_detect_error_total` metric (linkerd/linkerd2-proxy#1114)
* build(deps): bump trust-dns-resolver from `9048a39` to `9b46575` (linkerd/linkerd2-proxy#1139)
* build(deps): bump trust-dns-resolver from `9b46575` to `af83717` (linkerd/linkerd2-proxy#1140)
* metrics: Use `parking_lot::Mutex` in telemetry (linkerd/linkerd2-proxy#1142)
* metrics: factor out `NewService` for target-scoped metrics (linkerd/linkerd2-proxy#1117)
* build(deps): bump linkerd2-proxy-api from `5e4e190` to `e03dfe4` (linkerd/linkerd2-proxy#1143)
* build(deps): bump tonic-build from 0.5.0 to 0.5.1 (linkerd/linkerd2-proxy#1141)
sannimichaelse pushed a commit to sannimichaelse/linkerd2 that referenced this pull request Aug 1, 2021
This release replaces the `request_errors_total` metric with new metrics:
`inbound_http_errors_total` and `outbound_http_errors_total`. This
release also introduces new metrics--`inbound_tcp_accept_errors_total`
and `outbound_tcp_accept_errors_total`--that count proxy errors
encountered before a protocol can be detected.

---

* build(deps): Remove version comments from Actions (linkerd/linkerd2-proxy#1109)
* build(deps): bump mimalloc from 0.1.25 to 0.1.26 (linkerd/linkerd2-proxy#1110)
* build(deps): bump trust-dns-resolver from `ed9f05b` to `57b131f` (linkerd/linkerd2-proxy#1111)
* build(deps): bump tokio from 1.7.0 to 1.7.1 (linkerd/linkerd2-proxy#1113)
* build(deps): bump drain from 0.0.1 to 0.1.0 (linkerd/linkerd2-proxy#1112)
* build(deps): bump tracing-subscriber from 0.2.18 to 0.2.19 (linkerd/linkerd2-proxy#1116)
* build(deps): bump indexmap from 1.6.2 to 1.7.0 (linkerd/linkerd2-proxy#1120)
* build(deps): bump trust-dns-resolver from `57b131f` to `be0324a` (linkerd/linkerd2-proxy#1121)
* docs: Fix some compile errors that occur in `cargo doc` (linkerd/linkerd2-proxy#1115)
* build(deps): bump trust-dns-resolver from `be0324a` to `9048a39` (linkerd/linkerd2-proxy#1125)
* build(deps): bump tokio from 1.7.1 to 1.8.0 (linkerd/linkerd2-proxy#1126)
* build(deps): bump thiserror from 1.0.25 to 1.0.26 (linkerd/linkerd2-proxy#1127)
* build(deps): bump linkerd2-proxy-api from `48f13d6` to `def4e32` (linkerd/linkerd2-proxy#1128)
* tls: always use `tokio-rustls` re-export of `rustls` (linkerd/linkerd2-proxy#1122)
* build(deps): bump libc from 0.2.97 to 0.2.98 (linkerd/linkerd2-proxy#1129)
* build(deps): bump tokio from 1.8.0 to 1.8.1 (linkerd/linkerd2-proxy#1130)
* build(deps): bump tokio-stream from 0.1.6 to 0.1.7 (linkerd/linkerd2-proxy#1131)
* build(deps): bump hyper from 0.14.9 to 0.14.10 (linkerd/linkerd2-proxy#1132)
* Replace the `request_error_total` metric (linkerd/linkerd2-proxy#1133)
* build(deps): update `tonic`, `prost`, and  `linkerd2-proxy-api` (linkerd/linkerd2-proxy#1137)
* inbound: add `inbound_tls_detect_error_total` metric (linkerd/linkerd2-proxy#1114)
* build(deps): bump trust-dns-resolver from `9048a39` to `9b46575` (linkerd/linkerd2-proxy#1139)
* build(deps): bump trust-dns-resolver from `9b46575` to `af83717` (linkerd/linkerd2-proxy#1140)
* metrics: Use `parking_lot::Mutex` in telemetry (linkerd/linkerd2-proxy#1142)
* metrics: factor out `NewService` for target-scoped metrics (linkerd/linkerd2-proxy#1117)
* build(deps): bump linkerd2-proxy-api from `5e4e190` to `e03dfe4` (linkerd/linkerd2-proxy#1143)
* build(deps): bump tonic-build from 0.5.0 to 0.5.1 (linkerd/linkerd2-proxy#1141)
sannimichaelse pushed a commit to sannimichaelse/linkerd2 that referenced this pull request Aug 13, 2021
This release replaces the `request_errors_total` metric with new metrics:
`inbound_http_errors_total` and `outbound_http_errors_total`. This
release also introduces new metrics--`inbound_tcp_accept_errors_total`
and `outbound_tcp_accept_errors_total`--that count proxy errors
encountered before a protocol can be detected.

---

* build(deps): Remove version comments from Actions (linkerd/linkerd2-proxy#1109)
* build(deps): bump mimalloc from 0.1.25 to 0.1.26 (linkerd/linkerd2-proxy#1110)
* build(deps): bump trust-dns-resolver from `ed9f05b` to `57b131f` (linkerd/linkerd2-proxy#1111)
* build(deps): bump tokio from 1.7.0 to 1.7.1 (linkerd/linkerd2-proxy#1113)
* build(deps): bump drain from 0.0.1 to 0.1.0 (linkerd/linkerd2-proxy#1112)
* build(deps): bump tracing-subscriber from 0.2.18 to 0.2.19 (linkerd/linkerd2-proxy#1116)
* build(deps): bump indexmap from 1.6.2 to 1.7.0 (linkerd/linkerd2-proxy#1120)
* build(deps): bump trust-dns-resolver from `57b131f` to `be0324a` (linkerd/linkerd2-proxy#1121)
* docs: Fix some compile errors that occur in `cargo doc` (linkerd/linkerd2-proxy#1115)
* build(deps): bump trust-dns-resolver from `be0324a` to `9048a39` (linkerd/linkerd2-proxy#1125)
* build(deps): bump tokio from 1.7.1 to 1.8.0 (linkerd/linkerd2-proxy#1126)
* build(deps): bump thiserror from 1.0.25 to 1.0.26 (linkerd/linkerd2-proxy#1127)
* build(deps): bump linkerd2-proxy-api from `48f13d6` to `def4e32` (linkerd/linkerd2-proxy#1128)
* tls: always use `tokio-rustls` re-export of `rustls` (linkerd/linkerd2-proxy#1122)
* build(deps): bump libc from 0.2.97 to 0.2.98 (linkerd/linkerd2-proxy#1129)
* build(deps): bump tokio from 1.8.0 to 1.8.1 (linkerd/linkerd2-proxy#1130)
* build(deps): bump tokio-stream from 0.1.6 to 0.1.7 (linkerd/linkerd2-proxy#1131)
* build(deps): bump hyper from 0.14.9 to 0.14.10 (linkerd/linkerd2-proxy#1132)
* Replace the `request_error_total` metric (linkerd/linkerd2-proxy#1133)
* build(deps): update `tonic`, `prost`, and  `linkerd2-proxy-api` (linkerd/linkerd2-proxy#1137)
* inbound: add `inbound_tls_detect_error_total` metric (linkerd/linkerd2-proxy#1114)
* build(deps): bump trust-dns-resolver from `9048a39` to `9b46575` (linkerd/linkerd2-proxy#1139)
* build(deps): bump trust-dns-resolver from `9b46575` to `af83717` (linkerd/linkerd2-proxy#1140)
* metrics: Use `parking_lot::Mutex` in telemetry (linkerd/linkerd2-proxy#1142)
* metrics: factor out `NewService` for target-scoped metrics (linkerd/linkerd2-proxy#1117)
* build(deps): bump linkerd2-proxy-api from `5e4e190` to `e03dfe4` (linkerd/linkerd2-proxy#1143)
* build(deps): bump tonic-build from 0.5.0 to 0.5.1 (linkerd/linkerd2-proxy#1141)

Signed-off-by: Sanni Michael <sannimichaelse@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants