Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Liveness probes for control plane components #1116

Closed
grampelberg opened this issue Jun 13, 2018 · 2 comments
Closed

Liveness probes for control plane components #1116

grampelberg opened this issue Jun 13, 2018 · 2 comments
Assignees
@klingerf
Labels
area/controller area/production
Milestone
Gibraltar

Comments

@grampelberg
Copy link
Contributor

When a control plane component has issues (prometheus freezing for example), there are no liveness checks to restart them. There should be liveness probes for each component in the control plane.
grampelberg added a commit that referenced this issue Jun 13, 2018
@grampelberg
Add readiness/liveness checks for third party components
0605749 
Any possible issues with the third party control plane components can wedge the services.

Take the best practices for prometheus/grafana and add them to our template. See #1116
@grampelberg grampelberg mentioned this issue Jun 14, 2018
Merged
@klingerf
Copy link
Member

👍 to this issue. I'd also like to add readiness probes for controller plane components that sync with the kubernetes API, and that's ticketed in #1013.

grampelberg added a commit that referenced this issue Jun 14, 2018
@grampelberg
Add readiness/liveness checks for third party components (#1121)
516807b 
* Add readiness/liveness checks for third party components

Any possible issues with the third party control plane components can wedge the services.

Take the best practices for prometheus/grafana and add them to our template. See #1116

* Update test fixtures for new output
@klingerf klingerf added this to the 0.6.0 milestone Jun 15, 2018
@klingerf klingerf mentioned this issue Jun 20, 2018
Merged
@klingerf klingerf self-assigned this Jul 11, 2018
@klingerf
Copy link
Member

Liveliness probes were added in #1121 and #1168. It's possible that down the road we'd want to make the liveliness endpoints more sophisticate (they're just a ping at this point), but I'm going to mark this as done for now.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@klingerf klingerf

Labels
area/controller area/production
Projects
None yet
Milestone
Gibraltar
Development

No branches or pull requests
2 participants
@klingerf @grampelberg