Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration tests should validate control plane container logs #2348

Closed
klingerf opened this issue Feb 22, 2019 · 1 comment
Closed

Integration tests should validate control plane container logs #2348

klingerf opened this issue Feb 22, 2019 · 1 comment
Assignees
@siggy
Labels
area/test priority/P0 Release Blocker

Comments

@klingerf
Copy link
Member

Feature Request

What problem are you trying to solve?

When manually vetting a Linkerd build, it's easy to forget to look in the control plane's logs for warnings or errors that might be indicative of a problem. It's frequently the case that control plane components are spewing warnings or errors, but we don't notice them until after the code has already been released (e.g. #2331).

How should the problem be solved?

Update test/install_test.go to start validating control plane logs, after the smoke test has run. In a fresh control plane install, there should not be any warnings or errors (if there are, we should fix that). So it should be possible for us to fail integration tests if any control plane component (including linkerd-proxy) emits warnings or errors.

Any alternatives you've considered?

Manual validation, but we often forget to do that.
@grampelberg grampelberg added the priority/P0 Release Blocker label Feb 22, 2019
@siggy siggy self-assigned this Feb 27, 2019
@klingerf
Copy link
Member Author

As part of this change, it would also be good to validate that no control plane containers have restarted after all integration tests have completed. That will help to catch issues like the one described in #2407.

siggy added a commit that referenced this issue Feb 28, 2019
@siggy
Introduce logging and restart integration tests
90390a7 
The integration tests deploy complete Linkerd environments into
Kubernetes, but do not check if the components are logging errors or
restarting.

Introduce integration tests to validation that all expected
control-plane containers (including `linkerd-proxy` and `linkerd-init`)
are found, logging no errors, and not restarting.

Fixes #2348

Signed-off-by: Andrew Seigner <siggy@buoyant.io>
siggy added a commit that referenced this issue Feb 28, 2019
@siggy
Introduce logging and restart integration tests
0032ced 
The integration tests deploy complete Linkerd environments into
Kubernetes, but do not check if the components are logging errors or
restarting.

Introduce integration tests to validation that all expected
control-plane containers (including `linkerd-proxy` and `linkerd-init`)
are found, logging no errors, and not restarting.

Fixes #2348

Signed-off-by: Andrew Seigner <siggy@buoyant.io>
siggy added a commit that referenced this issue Feb 28, 2019
@siggy
Introduce logging and restart integration tests
445ec6d 
The integration tests deploy complete Linkerd environments into
Kubernetes, but do not check if the components are logging errors or
restarting.

Introduce integration tests to validation that all expected
control-plane containers (including `linkerd-proxy` and `linkerd-init`)
are found, logging no errors, and not restarting.

Fixes #2348

Signed-off-by: Andrew Seigner <siggy@buoyant.io>
@siggy siggy mentioned this issue Feb 28, 2019
Merged
siggy added a commit that referenced this issue Mar 1, 2019
@siggy
Introduce logging and restart integration tests
ffffdb3 
The integration tests deploy complete Linkerd environments into
Kubernetes, but do not check if the components are logging errors or
restarting.

Introduce integration tests to validation that all expected
control-plane containers (including `linkerd-proxy` and `linkerd-init`)
are found, logging no errors, and not restarting.

Fixes #2348

Signed-off-by: Andrew Seigner <siggy@buoyant.io>
siggy added a commit that referenced this issue Mar 6, 2019
@siggy
Introduce logging and restart integration tests
aa9bc22 
The integration tests deploy complete Linkerd environments into
Kubernetes, but do not check if the components are logging errors or
restarting.

Introduce integration tests to validation that all expected
control-plane containers (including `linkerd-proxy` and `linkerd-init`)
are found, logging no errors, and not restarting.

Fixes #2348

Signed-off-by: Andrew Seigner <siggy@buoyant.io>
siggy added a commit that referenced this issue Mar 6, 2019
@siggy
Introduce logging and restart integration tests (#2414)
d850b02 
The integration tests deploy complete Linkerd environments into
Kubernetes, but do not check if the components are logging errors or
restarting.

Introduce integration tests to validation that all expected
control-plane containers (including `linkerd-proxy` and `linkerd-init`)
are found, logging no errors, and not restarting.

Fixes #2348

Signed-off-by: Andrew Seigner <siggy@buoyant.io>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@siggy siggy

Labels
area/test priority/P0 Release Blocker
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@klingerf @grampelberg @siggy