Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxy: Clarify Outbound::recognize #1144

Merged
merged 8 commits into from
Jun 19, 2018
Merged

proxy: Clarify Outbound::recognize #1144

merged 8 commits into from
Jun 19, 2018

Commits on Jun 18, 2018

  1. proxy: Clarify Outbound::recognize

    The comments in Outbound::recognize had become somewhat stale as the
    logic changed. Furthermore, this implementation may be easier to
    understand if broken into smaller pieces.
    
    This change reorganizes the Outbound:recognize method into helper
    methods--`destination`, `host_port`, and `normalize`--each with
    accompanying docstrings that more accurately reflect the current
    implementation.
    
    This also has the side-effect benefit of eliminating a string clone on
    every request.
    olix0r committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    5b86cb1 View commit details
    Browse the repository at this point in the history
  2. review feedback

    olix0r committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    6fd4435 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8429708 View commit details
    Browse the repository at this point in the history
  4. touchup

    olix0r committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    c090d73 View commit details
    Browse the repository at this point in the history
  5. inspect_err isn't real

    olix0r committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    77d36cd View commit details
    Browse the repository at this point in the history
  6. +missing whitespace

    olix0r committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    af0d763 View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2018

  1. Configuration menu
    Copy the full SHA
    2093817 View commit details
    Browse the repository at this point in the history
  2. comment typo

    olix0r committed Jun 19, 2018
    Configuration menu
    Copy the full SHA
    0f4f672 View commit details
    Browse the repository at this point in the history