Switch to ant sider/content Layout modules, to help style sidebar #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmars
force-pushed
the
rmars/sidebar-extension
branch
from
5cdf9b7
to
c3e9e2a
Compare
added 2 commits
January 23, 2018 15:14
Fixes the problem of the sidebar not extending all the way on long pages. Signed-off-by: Risha Mars <mars@buoyant.io>
…item was selected Signed-off-by: Risha Mars <mars@buoyant.io>
rmars
force-pushed
the
rmars/sidebar-extension
branch
from
c3e9e2a
to
3b56dbf
Compare
klingerf
approved these changes
Jan 24, 2018
web/app/css/sidebar.css
Outdated
| background-color: #091B39; | ||
| color: white; | ||
| height: 100vh; | ||
| min-height: 200vh; |
There was a problem hiding this comment.
I think we should change this to min-height: 100vh;. Otherwise we'll display a vertical scrollbar on short pages that would not otherwise have a scrollbar.
Signed-off-by: Risha Mars <mars@buoyant.io>
franziskagoltz
approved these changes
Jan 24, 2018
hawkw
pushed a commit
that referenced
this pull request
Jan 24, 2018
* Switch to ant sider/content Layout modules, to help style sidebar This fixes the problem of the sidebar not extending all the way on long pages. * Fix a bug where the autocomplete options weren't being reset when an item was selected
ihcsim
pushed a commit
that referenced
this pull request
Feb 27, 2019
This picks up the following commits: * 0fe8063 replace with (#2370) (#201) * 1ea7559 Minor cleanup in the config tests (#188) * d0ef56b Update *ring* to 0.14.6 (#197) * c54377f fs-watch: Use a properly sized buffer for inotify events (#195) * 23e02a6 Update Router to wait for inner poll_ready before calling inner call * 2de8e9b Update metrics quickcheck to 0.8, and hyper to 0.12.24 * d1bbd4b make: Optionally include debug symbols with builds (#193) * 738a541 Fix compilation warnings in fs-watch (#192) * 6cc7558 Apply rustfmt (#191) Signed-off-by: Ivan Sim <ivan@buoyant.io>
khappucino
pushed a commit
to Nordstrom/linkerd2
that referenced
this pull request
Mar 5, 2019
Signed-off-by: Alex Leong <alex@buoyant.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #72
Before:
After:
Signed-off-by: Risha Mars mars@buoyant.io