Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix memory leak in new column family metadata #129

Merged
merged 1 commit into from
Nov 9, 2023
Merged

fix memory leak in new column family metadata #129

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions cf_metadata.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package grocksdb

// #include "rocksdb/c.h"
import "C"
import "unsafe"

// ColumnFamilyMetadata contains metadata info of column family.
type ColumnFamilyMetadata struct {
Expand Down Expand Up @@ -98,10 +99,12 @@ func sstMetas(c *C.rocksdb_level_metadata_t) []SstMetadata {

var ln C.size_t
sk := C.rocksdb_sst_file_metadata_get_smallestkey(sm, &ln)
metas[i].smallestKey = charToByte(sk, ln)
metas[i].smallestKey = C.GoBytes(unsafe.Pointer(sk), C.int(ln))
C.rocksdb_free(unsafe.Pointer(sk))

sk = C.rocksdb_sst_file_metadata_get_largestkey(sm, &ln)
metas[i].largestKey = charToByte(sk, ln)
metas[i].largestKey = C.GoBytes(unsafe.Pointer(sk), C.int(ln))
C.rocksdb_free(unsafe.Pointer(sk))

C.rocksdb_sst_file_metadata_destroy(sm)
}
Expand Down
Loading