-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
an aborted fit with method='least_squares'
does not report correct fit results and statistics
#896
Comments
@newville Thanks for picking this up. It seems also basinhopping, ampgo and shgo have the same issue. Tested with:
|
@eendebakpt Thanks for catching that I guess that should not be too surprising that other methods have a similar problem. |
@eendebakpt I adapted the PR at #897 to handle (and test) aborted fits for more methods, and make sure that they also end up with clearly aborted but still not-useless values for fit statistics. |
Description
As shown in #894, a fit with
method='least_squares'
that aborts, perhaps due to too many function evaluations, does not properly evaluate the residual and fit statistics with "last/best available parameter values".Note that other methods do evaluate the residual and fit statistics with "last/best available parameter values" when the fit is aborted.
A Minimal, Complete, and Verifiable example
see #894
Link(s)
see #894
The text was updated successfully, but these errors were encountered: