Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] improvement request for skip_header, autodetect_column_names setting #77

Open
dharada opened this issue Dec 2, 2019 · 1 comment

Comments

@dharada
Copy link

dharada commented Dec 2, 2019

This is not feature request, but Docs improvement request by a user.

  • Version: 3.0.10

https://www.elastic.co/guide/en/logstash/current/plugins-filters-csv.html#plugins-filters-csv-skip_header

Define whether the header should be skipped. Defaults to false. 
If set to true, the header will be skipped. Assumes that header is not repeated within further rows as such rows will also be skipped. 
If skip_header is set without autodetect_column_names being set then columns should be set which will result in the skipping of any row that exactly matches the specified column values. 
If skip_header and autodetect_column_names are specified then columns should not be specified, 
in this case autodetect_column_names will fill the columns setting in the background, from the first event seen, and any subsequent values that match what was autodetected will be skipped.

As current official document says, we can confirm below behavior.

product behavior

When both skip_header and autodetect_column_names are specified as true, autodetect_column_names uses the first event for auto-generate the column names, and first event is skipped by skip_header(true). so csv filtering process is taken from second event which doesn't match first event.

a suggestion

How about adding above product behavior as a clear example ? (if this make documents more understandable.)
@AndyHunt66
Copy link

Also on the same topic: #79

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants