Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TaggedLogging in Rails 7.0 #19

Merged
merged 2 commits into from
Jul 12, 2023
Merged

Fix TaggedLogging in Rails 7.0 #19

merged 2 commits into from
Jul 12, 2023

Conversation

PetrHeinz
Copy link
Contributor

In Rails 7.0, ActiveSupport::TaggedLogging::Formatter#current_tags uses ActiveSupport::IsolatedExecutionStat instead of Thread.current.

Should fix tests in logtail-ruby-rails for Rails ≥ 7.0

@PetrHeinz PetrHeinz requested a review from curusarn July 12, 2023 12:20
curusarn
curusarn approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@curusarn curusarn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@PetrHeinz PetrHeinz merged commit a15be77 into main Jul 12, 2023
15 checks passed
@PetrHeinz PetrHeinz deleted the ph/fix-tagged-logging-rails-7 branch July 12, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curusarn curusarn curusarn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PetrHeinz @curusarn