Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leading space in output is not trimmed #66

Open
Propheticus opened this issue Mar 31, 2024 · 4 comments
Open

Leading space in output is not trimmed #66

Propheticus opened this issue Mar 31, 2024 · 4 comments

Comments

@Propheticus
Copy link

Propheticus commented Mar 31, 2024

As the title says, when executing a piece of text as a prompt the generated output is pasted in with a leading space.

This is a small issue if the output is text, but if the output is a (markdown) table this is not rendered correctly.

Obsidian_BMO

EDIT: After some investigation I found it's actually the LLM inference solution I'm using that's starting its responses with a space.
Still might be a good idea to trim leading spaces. Especially when output is used in titles which becomes file names.

@Propheticus
Copy link
Author

Just tested the chat and this also contain the leading space. It's not only the "prompt select generate".

@Propheticus Propheticus changed the title Output of a "prompt select generate" contains a leading space Output contains a leading space Mar 31, 2024
@Propheticus
Copy link
Author

this also seems to be causing #67

@Propheticus Propheticus changed the title Output contains a leading space Leading space in output is not trimmed Mar 31, 2024
@Propheticus
Copy link
Author

Caused by janhq/jan#2548

@longy2k
Copy link
Owner

longy2k commented May 23, 2024

v2.1.0

The editor and chat responses are now trimmed.

Let me know if you still run into this issue, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants