Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lua_clonefunction definition has redundant LUA_API prefix #411

Closed
aero-the-synaptic-electrician opened this issue Mar 6, 2022 · 1 comment · Fixed by #422
Closed

lua_clonefunction definition has redundant LUA_API prefix #411

aero-the-synaptic-electrician opened this issue Mar 6, 2022 · 1 comment · Fixed by #422

Comments

@aero-the-synaptic-electrician
Copy link

aero-the-synaptic-electrician commented Mar 6, 2022 •
edited
Loading

(redacted)
@zeux
Copy link
Collaborator

zeux commented Mar 9, 2022

I think that's actually a legitimate problem with lua_clonefunction which should not have had the LUA_API define in the implementation. The rules for declspecs are annoyingly complicated so this is probably okay for DLL export but may not be okay for some other specifiers, so it feels good to be consistent.

@zeux zeux reopened this Mar 9, 2022
@zeux zeux changed the title Export typo lua_clonefunction definition has redundant LUA_API prefix Mar 11, 2022
@zeux zeux mentioned this issue Mar 18, 2022
Merged
@zeux zeux closed this as completed in #422 Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Sync to upstream/release/519 luau-lang/luau
2 participants
@zeux @aero-the-synaptic-electrician