Prevent overflow in lua_newuserdatadtor #639
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case a large userdata size is passed to
lua_newuserdatadtor
it might overflow the size resulting inluaU_newudata
actually allocating the object without a memory error. This will then result in overwriting part of themetatable
pointer of the userdata.This PR fixes this issue by checking for the overflow and in such cases pass a size value which will cause a memory error in
luaU_newudata
.