Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong DRM_FOURCC for 32 bit? #235

Open
johado opened this issue Aug 24, 2022 · 3 comments
Open

Wrong DRM_FOURCC for 32 bit? #235

johado opened this issue Aug 24, 2022 · 3 comments
Labels

Comments

@johado
Copy link
Contributor

johado commented Aug 24, 2022

I'm trying to get an lvgl application running on an embedded linux device that uses the DRM framework and and a MIPI DSI panel using the panel-simple driver.
The current code fails select a plane that is compatible since the closest supported format is XR24 and not AR24, unless i do the following change in drm.c

#if LV_COLOR_DEPTH == 32
-#define DRM_FOURCC DRM_FORMAT_ARGB8888
+#define DRM_FOURCC DRM_FORMAT_XRGB8888
#elif LV_COLOR_DEPTH == 16

Is that the right thing to do or should the 32 bit format be configurable?
(On another device the same application would run when configured to use FBDEV or SDL)

@kisvegabor
Copy link
Member

kisvegabor commented Aug 28, 2022

Is that the right thing to do or should the 32 bit format be configurable?

I'd make DRM_FORMAT_XRGB8888 the default and add config to use the ARGB version.

An other option would be to try DRM_FORMAT_XRGB8888 and if it's not good use DRM_FORMAT_XRGB8888 as a fallback.

@superna9999
Copy link
Contributor

@kisvegabor yes argb should be a fallback of xrgb

@stale
Copy link

stale bot commented Apr 20, 2023

This issue or pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants