Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use use apiextensions.k8s.io/v1 for CRDs (Make it compitible with k8s 1.22) #3192

Closed
t83714 opened this issue Jul 19, 2021 · 1 comment
Closed
Assignees
Milestone

Comments

@t83714
Copy link
Contributor

t83714 commented Jul 19, 2021

Use use apiextensions.k8s.io/v1 for CRDs (Make it compitible with k8s 1.22)

Currently, if you deploy magda with openfaas (in k8s 1.19), you will see the following warning:

W0719 12:05:35.966133   73955 warnings.go:70] apiextensions.k8s.io/v1beta1 CustomResourceDefinition is deprecated in v1.16+, unavailable in v1.22+; use apiextensions.k8s.io/v1 CustomResourceDefinition
W0719 12:05:38.000882   73955 warnings.go:70] apiextensions.k8s.io/v1beta1 CustomResourceDefinition is deprecated in v1.16+, unavailable in v1.22+; use apiextensions.k8s.io/v1 CustomResourceDefinition

We should upgrade the CRDs to use apiextensions.k8s.io/v1 in order to be compatible with k8s 1.22.

please note: In apiextensions.k8s.io/v1beta1, there was a version field instead of versions. The version field is deprecated and optional, but if it is not empty, it must match the first item in the versions field.
see here: https://kubernetes.io/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definition-versioning/

Magda's forked openfaas chart is here: https://github.com/magda-io/openfaas-helm-chart

@t83714
Copy link
Contributor Author

t83714 commented Dec 15, 2021

closed via PR #3280

@t83714 t83714 closed this as completed Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant