Getting PHP Fatal Error on getPrice() #5519

hvohra · 2016-07-07T12:30:39Z

Steps to reproduce

I have installed new magento 2.1 with mysql 5.6 , php7 on ubunu 15. Everything works except sometimes when I add a prod to cart , checkout, or login, I get the following error:

[Thu Jul 07 07:26:27.251375 2016] [:error] [pid 5731] [client 127.0.0.1:59868] PHP Fatal error: Uncaught Error: Call to a member function getPrice() on null in /var/www/magento2/vendor/magento/module-configurable-product/Model/Product/Type/Configurable/Price.php:43\nStack trace:\n#0 /var/www/magento2/vendor/magento/module-catalog/Model/Product.php(555): Magento\ConfigurableProduct\Model\Product\Type\Configurable\Price->getPrice(Object(Magento\Catalog\Model\Product\Interceptor))\n#1 /var/www/magento2/var/generation/Magento/Catalog/Model/Product/Interceptor.php(89): Magento\Catalog\Model\Product->getPrice()\n#2 /var/www/magento2/vendor/magento/module-quote/Model/Quote/Address/Total/Subtotal.php(110): Magento\Catalog\Model\Product\Interceptor->getPrice()\n#3 /var/www/magento2/vendor/magento/module-quote/Model/Quote/Address/Total/Subtotal.php(53): Magento\Quote\Model\Quote\Address\Total\Subtotal->_initItem(Object(Magento\Quote\Model\Quote\Address), Object(Magento\Quote\Model\Quote\Item))\n#4 /var/www/magento2/vendor/magento/module-quote/Model/Quote/TotalsCollector.php(265): Magento\Quote\Model\Quote\Address\Total in /var/www/magento2/vendor/magento/module-configurable-product/Model/Product/Type/Configurable/Price.php on line 43, referer:

Please help

tipofloe · 2016-07-19T22:14:46Z

I had the same problem. I flushed all Cache from Magento 2 and then reindexed and now it's working.

veloraven · 2016-08-02T09:27:26Z

@hvohra thank you for your report.
Could you please provide more specific cases when the issue reproduces? Maybe additional settings, product type, etc. As it may be very hard or impossible to reproduce on other environment the issue which appears "sometimes" only.

MorganGonzales · 2016-08-18T06:39:03Z

Also happens to me. I'm using Magento 2.1. It occurs during viewing cart when one of the items in the cart is set to "Out of Stock".

Replication step:

Add a product to cart.
(While product is on cart) Set added product to "Out Of Stock" in Admin
Going back to store site, go to Cart page (View Cart).

Result:
Fatal error: Uncaught Error: Call to a member function getPrice() on null in /Users/user/Sites/classic-spirit/vendor/magento/module-configurable-product/Model/Product/Type/Configurable/Price.php:43 Stack trace: #0 /Users/user/Sites/classic-spirit/vendor/magento/module-catalog/Model/Product.php(555): Magento\ConfigurableProduct\Model\Product\Type\Configurable\Price->getPrice(Object(Magento\Catalog\Model\Product\Interceptor))
#1 /Users/user/Sites/classic-spirit/var/generation/Magento/Catalog/Model/Product/Interceptor.php(89): Magento\Catalog\Model\Product->getPrice()
#2 /Users/user/Sites/classic-spirit/vendor/magento/module-quote/Model/Quote/Address/Total/Subtotal.php(110): Magento\Catalog\Model\Product\Interceptor->getPrice()
#3 /Users/user/Sites/classic-spirit/vendor/magento/module-quote/Model/Quote/Address/Total/Subtotal.php(53): Magento\Quote\Model\Quote\Address\Total\Subtotal->_initItem(Object(Magento\Quote\Model\Quote\Address), Object(Magento\Quote\Model\Quote\Item))
#4 /Users/user/Sites/classic-spirit/vendor/magento/ in /Users/user/Sites/classic-spirit/vendor/magento/module-configurable-product/Model/Product/Type/Configurable/Price.php on line 43

isitnikov · 2016-08-27T02:56:50Z

Internal ticket: MAGETWO-57719

webspeaks · 2016-09-18T09:57:22Z

Any update on this? I am getting this error very frequently..

hvohra · 2016-09-19T03:28:55Z

I had this issue couple of months ago so and I think I was able to resolve (or get around) this issue by downgrading my php from 7 to 5.6.

paalsoberg · 2016-09-21T09:42:12Z

Hi, any update on when this will be fixed as Paypal is unusable if you have configurable products @maksek @veloraven @isitnikov

antbates91 · 2016-09-23T13:17:24Z

👍 on this we are having the exact same issue here using magento 2.1 with mysql 5.6 , php 7.0.8

It happens for us under the following circumstances:

- A user logs into their account on the front end and adds a product to their cart.
- They then log out or leave the site, magento saves the cart items .
- Some time passes and the product then goes out of stock.
- The user then comes back to log into the site on the front end while this product is still out of stock.
- The above error is then displayed as Magento tries to load up the saved cart items.

ifuents · 2016-10-06T08:11:00Z

We are having the same issue MhorGonzales describes.
Any update so far?

mark-netalico · 2016-10-10T13:15:44Z

I'm also running into this.

tkacheva · 2016-10-18T09:08:29Z

Issue has been fixed in current develop branch c966dc1
Please check. Reopen if needed

hostep · 2017-02-24T15:13:07Z

Also running into this issue, using Magento CE 2.1.4
Don't know how to reproduce, but suddenly we started having this problem.

The above commit mentioned by @tkacheva obviously has nothing to do with this. It was included in Magento 2.1.3, but it doesn't help with this particular problem.

We just fixed it as follows (not sure if this is the correct way, but whatever):

diff --git a/Model/Product/Type/Configurable/Price.php b/Model/Product/Type/Configurable/Price.php
index fe4428cf589..3704b47f516 100644
--- a/Model/Product/Type/Configurable/Price.php
+++ b/Model/Product/Type/Configurable/Price.php
@@ -39,7 +39,7 @@ class Price extends \Magento\Catalog\Model\Product\Type\Price
      */
     public function getPrice($product)
     {
-        if ($product->getCustomOption('simple_product')) {
+        if ($product->getCustomOption('simple_product') && $product->getCustomOption('simple_product')->getProduct()) {
             return $product->getCustomOption('simple_product')->getProduct()->getPrice();
         } else {
             return 0;

orlangur · 2017-02-24T15:21:54Z

@maghamed, looks like another good place for defensive programming to be applied :)

peterhirn · 2017-03-23T18:28:39Z

I had to patch two additional files. My cart included a outdated configurable product.

diff --git a/app/code/Magento/ConfigurableProduct/Block/Cart/Item/Renderer/Configurable.php b/app/code/Magento/ConfigurableProduct/Block/Cart/Item/Renderer/Configurable.php
index b401e1a..ab8d764 100644
--- a/app/code/Magento/ConfigurableProduct/Block/Cart/Item/Renderer/Configurable.php
+++ b/app/code/Magento/ConfigurableProduct/Block/Cart/Item/Renderer/Configurable.php
@@ -65,7 +65,7 @@ class Configurable extends Renderer implements IdentityInterface
             self::CONFIG_THUMBNAIL_SOURCE,
             \Magento\Store\Model\ScopeInterface::SCOPE_STORE
         ) == ThumbnailSource::OPTION_USE_PARENT_IMAGE ||
-            !($this->getChildProduct()->getThumbnail() && $this->getChildProduct()->getThumbnail() != 'no_selection')
+            !($this->getChildProduct() && $this->getChildProduct()->getThumbnail() && $this->getChildProduct()->getThumbnail() != 'no_selection')
         ) {
             $product = $this->getProduct();
         } else {
diff --git a/app/code/Magento/ConfigurableProduct/CustomerData/ConfigurableItem.php b/app/code/Magento/ConfigurableProduct/CustomerData/ConfigurableItem.php
index 7614eef..dab847d 100644
--- a/app/code/Magento/ConfigurableProduct/CustomerData/ConfigurableItem.php
+++ b/app/code/Magento/ConfigurableProduct/CustomerData/ConfigurableItem.php
@@ -60,7 +60,7 @@ class ConfigurableItem extends DefaultItem
         );

         $product = $config == ThumbnailSource::OPTION_USE_PARENT_IMAGE
-            || (!$this->getChildProduct()->getThumbnail() || $this->getChildProduct()->getThumbnail() == 'no_selection')
+            || (!$this->getChildProduct() || !$this->getChildProduct()->getThumbnail() || $this->getChildProduct()->getThumbnail() == 'no_selection')
             ? $this->getProduct()
             : $this->getChildProduct();

diff --git a/app/code/Magento/ConfigurableProduct/Model/Product/Type/Configurable/Price.php b/app/code/Magento/ConfigurableProduct/Model/Product/Type/Configurable/Price.php
index fe4428c..3704b47 100644
--- a/app/code/Magento/ConfigurableProduct/Model/Product/Type/Configurable/Price.php
+++ b/app/code/Magento/ConfigurableProduct/Model/Product/Type/Configurable/Price.php
@@ -39,7 +39,7 @@ class Price extends \Magento\Catalog\Model\Product\Type\Price
      */
     public function getPrice($product)
     {
-        if ($product->getCustomOption('simple_product')) {
+        if ($product->getCustomOption('simple_product') && $product->getCustomOption('simple_product')->getProduct()) {
             return $product->getCustomOption('simple_product')->getProduct()->getPrice();
         } else {
             return 0;

Pigau · 2017-04-05T15:45:29Z

We has the same issue (on magento 2.1.4), and the previous patch work for us, thank @peterhirn.
The problem seem to occur when the children product of a configurable is considered as deleted in module-quote/Model/ResourceModel/Quote/Item/Collection.php:258

leandrosunrise · 2017-05-19T17:27:42Z

@peterhirn patch fixed my Issue is this going to be pushed on the next release of magento?

peterhirn · 2017-05-19T17:37:40Z

@leandrosunrise as this is just an extended hack based on the patch from @hostep I think someone more familiar with the code should check this and create a pull request.

stephan-cream · 2017-08-14T15:11:28Z

@peterhirn Although this hack prevents the error from showing it does not fix the issue of the simple product not being set within the protected $_product variable within vendor/magento/module-quote/Model/Quote/Item/Option.php.

Strangely the product option 'simple_product' does exist in the database within the table 'quote_item_option' and holds the correct product id towards the simple product in the value column.
While debugging i noticed that it does get the correct option from that table but never sets the product that is associated to it.

On a side note, i tried changing the stock settings for a Configurable product.
Namely by changing "Manage Stock" from Yes to No as this is what we generally use ourselves.
This somehow solved the issue for this specific product (do note we did several other changes on the product which had no effect) and showed the product properly in the cart.
Strangely once i change the settings back to what they were it will no longer give this error so it is not reliant on this setting.
Hence i believe this goes wrong in the indexing process, but as to why / where i am not yet sure.
Perhaps this information somehow helps others find the actual cause.

magento-team · 2017-09-04T16:32:10Z

Internal ticket to track issue progress: MAGETWO-72251

veloraven added the Progress: needs update label Aug 2, 2016

veloraven assigned veloraven and unassigned veloraven Aug 2, 2016

veloraven added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development bug report Component: Catalog and removed Progress: needs update labels Aug 31, 2016

maksek added 2.1.x labels Sep 13, 2016

tkacheva closed this as completed Oct 18, 2016

hostep mentioned this issue Jun 15, 2017

Setting 'show_out_of_stock' to 'No' has no effect #8566

Closed

jhruehl mentioned this issue Jul 11, 2017

Getting PHP Fatal Error on getPrice() #10206

Closed

hostep mentioned this issue Sep 2, 2017

Backport of MAGETWO-65607 for Magento 2.1: [GitHub][PR] Check return … #10750

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Getting PHP Fatal Error on getPrice() #5519

Getting PHP Fatal Error on getPrice() #5519

hvohra commented Jul 7, 2016

tipofloe commented Jul 19, 2016 •

edited

Loading

veloraven commented Aug 2, 2016

MorganGonzales commented Aug 18, 2016 •

edited

Loading

isitnikov commented Aug 27, 2016 •

edited by maksek

Loading

webspeaks commented Sep 18, 2016

hvohra commented Sep 19, 2016

paalsoberg commented Sep 21, 2016

antbates91 commented Sep 23, 2016 •

edited

Loading

ifuents commented Oct 6, 2016 •

edited

Loading

mark-netalico commented Oct 10, 2016

tkacheva commented Oct 18, 2016

hostep commented Feb 24, 2017

orlangur commented Feb 24, 2017

peterhirn commented Mar 23, 2017 •

edited

Loading

Pigau commented Apr 5, 2017

leandrosunrise commented May 19, 2017

peterhirn commented May 19, 2017

stephan-cream commented Aug 14, 2017

magento-team commented Sep 4, 2017

Getting PHP Fatal Error on getPrice() #5519

Getting PHP Fatal Error on getPrice() #5519

Comments

hvohra commented Jul 7, 2016

Steps to reproduce

tipofloe commented Jul 19, 2016 • edited Loading

veloraven commented Aug 2, 2016

MorganGonzales commented Aug 18, 2016 • edited Loading

isitnikov commented Aug 27, 2016 • edited by maksek Loading

webspeaks commented Sep 18, 2016

hvohra commented Sep 19, 2016

paalsoberg commented Sep 21, 2016

antbates91 commented Sep 23, 2016 • edited Loading

ifuents commented Oct 6, 2016 • edited Loading

mark-netalico commented Oct 10, 2016

tkacheva commented Oct 18, 2016

hostep commented Feb 24, 2017

orlangur commented Feb 24, 2017

peterhirn commented Mar 23, 2017 • edited Loading

Pigau commented Apr 5, 2017

leandrosunrise commented May 19, 2017

peterhirn commented May 19, 2017

stephan-cream commented Aug 14, 2017

magento-team commented Sep 4, 2017

tipofloe commented Jul 19, 2016 •

edited

Loading

MorganGonzales commented Aug 18, 2016 •

edited

Loading

isitnikov commented Aug 27, 2016 •

edited by maksek

Loading

antbates91 commented Sep 23, 2016 •

edited

Loading

ifuents commented Oct 6, 2016 •

edited

Loading

peterhirn commented Mar 23, 2017 •

edited

Loading