forked from binary-com/deriv-app
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sergei / chore: migrate open-positions to tsx #40
Merged
mahdiyeh-deriv
merged 10 commits into
mahdiyeh-deriv:Improvement/72232/Reports_TS_migration
from
sergei-deriv:sergei/73992/ts-migration-open-positions
Jan 26, 2023
Merged
Changes from 7 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
cf05b3e
chore: convert open-positions to tsx
sergei-deriv 9673fe7
fix: add React.PropsWithChildren to tabs.tsx
sergei-deriv 7b957ef
fix: change Tabs type
sergei-deriv 0814e8d
fix: add/change some types and fix some undefined values
sergei-deriv 2285054
refactor: use Return Early pattern for contract-card-sell component
sergei-deriv e4bda7b
chore: delete commented lines
sergei-deriv 5c13c20
chore: add moment as dev dependency
sergei-deriv 2f5787d
chore: commit to check circleCI
sergei-deriv 7158294
fix: change back tabs.tsx
sergei-deriv 993b611
fix: change React.Fragment to null
sergei-deriv File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why we are returning empty fragment? isn't to return
null
instead?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did it because component is waiting JSX. I'll change it now