Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TIMELAPSE_TAKE_FRAME.is_paused variable updated to early #169

Open
Clon1998 opened this issue Jul 3, 2024 · 0 comments
Open

TIMELAPSE_TAKE_FRAME.is_paused variable updated to early #169

Clon1998 opened this issue Jul 3, 2024 · 0 comments

Comments

@Clon1998
Copy link

Clon1998 commented Jul 3, 2024

Hey,
After some users reported (Clon1998/mobileraker_companion#82) that my companion still issues notifications while the plugin records a frame, I debugged my code and was able to locate the issue.

The root cause is the GCode macro TIMELAPSE_TAKE_FRAME. To be more precise, the timing when it updates the is_paused variable. Basically, at the moment, the GCode sets the is_paused variable to false before the printer actually reports that it's back in the printing state. This causes my companion to still be in the paused state while the is_paused is already set to false resulting in a new notification.

On my end, I updated my code to include a workaround that internally resets the variable only after the printer actually reports that it changed its state back to printing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant