Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keepers can get stuck in an infinite loop if they run out of gas #39

Open
ghost opened this issue Oct 10, 2017 · 1 comment
Open

Keepers can get stuck in an infinite loop if they run out of gas #39

ghost opened this issue Oct 10, 2017 · 1 comment
Labels

Comments

@ghost
Copy link

ghost commented Oct 10, 2017

If a keeper wants to sends 4 transactions at once (could be a sai-maker-otc keeper with a few bands configured) but the ETH available in its account is enough to send only lets say three of them, the keeper can get infinitely stuck.

The reason of it is that web3.eth.sendTransaction will not immediately fail for the fourth transaction if they all will get sent almost at the same time, although Parity will silently reject it with a Transaction marked invalid (hash .....) message appearing in console. As the rejection is silent (web3.eth.sendTransaction seemed to be successful from the keeper point of view), the keeper will infinitely wait for that transactions receipt to appear, which will never happen. This will make it stuck forever.

@ghost ghost added the bug label Oct 10, 2017
@ghost
Copy link
Author

ghost commented Oct 10, 2017

Hmm.. maybe calling a getTransactionByHash(...) to check if that transaction is still in the pool...?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

0 participants