Should strip whitespace

[FichteFoll]

The default implementation of SecretsSettingsSource strips the read file contents of any whitespace but this one here does not.

Setting str_strip_whitespace in the model_config does not seem to have any effect on this either.

[makukha]

Thank you! This is definitely a bug.

[makukha]

Btw, I just checked that str_strip_whitespace is not respected by original SecretsSettingsSource:

def test_str_strip_whitespace_not_respected(secrets_dir):
    class Settings(BaseSettings):
        key: str

        model_config = SettingsConfigDict(
            secrets_dir=secrets_dir,
            str_strip_whitespace=False,
        )

    secrets_dir.add_files(
        ('key', ' value '),
    )

    conf = Settings()
    assert conf.key == 'value'  # str_strip_whitespace not respected

[makukha]

@FichteFoll thank you for the bug report. The fix was trivial and already merged to main branch. I will update PyPI release as soon as all bugs reported will be fixed (a couple of days at most).

Thank you for your interest in the package!

[FichteFoll]

Btw, I just checked that str_strip_whitespace is not respected by original SecretsSettingsSource:

Indeed, it was simply always stripped. Perhaps this is an upstream bug.

I simply monkey-patched FileSecretsSettingsSource.load_secrets while waiting for a patch but will gladly remove it once the new version is out.

Thanks for adapting this into a package until this feature hopefully lands in the mainline pydantic-settings project.

[makukha]

I simply monkey-patched FileSecretsSettingsSource.load_secrets while waiting for a patch but will gladly remove it once the new version is out.

The new version 0.3.0 with all your suggestions and bug reports fixed is released on PyPI.
Thank you for the feedback!

Thanks for adapting this into a package until this feature hopefully lands in the mainline pydantic-settings project.

There's already a PR to pydantic_settings for multiple secrets_dir waiting to be merged. And yes, the plan is to update pydantic_settings with at least some of features from this package.