From e4041cf03bd1ddce668309ca028a3d6b5c6f7347 Mon Sep 17 00:00:00 2001 From: Mordechai Dror Date: Tue, 6 Aug 2024 20:35:07 +0300 Subject: [PATCH] [@mantine/core] DatePickerInput: Fix incorrect `aria-label` being set on the input element (#6530) according to accessibility parts of DatePickerInput docs it is said that if `label` prop is set, input will be accessible it is not required to set `aria-label`. But since there was assignment of `aria-label` inside PickerInputBase on Input it essentially overrode the label from InputWrapper connected with `htmlFor` attribute. It made component harder to use inside e2e tests that rely on labels for element locators, since component locator should be dynamic or `aria-label` attribute must be passed alongside with `label` attribute --- .../dates/src/components/PickerInputBase/PickerInputBase.tsx | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/@mantine/dates/src/components/PickerInputBase/PickerInputBase.tsx b/packages/@mantine/dates/src/components/PickerInputBase/PickerInputBase.tsx index 299ce97bec..8f2927c4cc 100644 --- a/packages/@mantine/dates/src/components/PickerInputBase/PickerInputBase.tsx +++ b/packages/@mantine/dates/src/components/PickerInputBase/PickerInputBase.tsx @@ -172,7 +172,6 @@ export const PickerInputBase = factory((_props, ref) => >