Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

outer is missing in the resulting geometry #79

Closed
Sumbera opened this issue Dec 19, 2016 · 3 comments
Closed

outer is missing in the resulting geometry #79

Sumbera opened this issue Dec 19, 2016 · 3 comments

Comments

@Sumbera
Copy link

Sumbera commented Dec 19, 2016

it is impossible to determine outer or inner rings in multi polygon case, added outer to the resulting geometry #78

@mourner
Copy link
Member

mourner commented Dec 19, 2016

geojson-vt encodes outer/inner rings through signed area according to the vector tile specification v2. See https://github.com/mapbox/vector-tile-spec/tree/master/2.1#4344-polygon-geometry-type

@mourner mourner closed this as completed Dec 19, 2016
@Sumbera
Copy link
Author

Sumbera commented Dec 19, 2016

... so to get this info I need to calculate the area first and check its sign ? really ?
other refs:
mapbox/vector-tile-spec#78
mapbox/mapnik-vector-tile#59

@mourner
Copy link
Member

mourner commented Dec 20, 2016

@Sumbera yes. This is not ideal obviously, but was the only option that didn't require doing a major breaking change to the vector tile specification. We want to address that with the next revision of the spec, tracked in mapbox/vector-tile-spec#77.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants