Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use npm shrinkwrap #1607

Closed
jfirebaugh opened this issue Oct 8, 2015 · 0 comments
Closed

use npm shrinkwrap #1607

jfirebaugh opened this issue Oct 8, 2015 · 0 comments

Comments

@jfirebaugh
Copy link
Contributor

https://docs.npmjs.com/cli/shrinkwrap

We generate prebuilt bundles that include all dependencies, and ideally these bundles include the dependencies at versions that we have been commonly testing with. We want to avoid the scenario where a dependency happens to introduce a breaking change just as a new version of mapbox-gl-js is going to press, and it gets picked up by the automatic build.

This would also be an alternative fix for #1600. I'm assuming that if you are using shrinkwrap, npm install will update any outdated dependencies to the versions specified in npm-shrinkwrap.json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant