Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to clearly differentiate between "interaction handler" events and "camera mutation" events #3357

Open
4 tasks
lucaswoj opened this issue Oct 12, 2016 · 5 comments

Comments

@lucaswoj
Copy link
Contributor

lucaswoj commented Oct 12, 2016

Some interaction handlers fire events that are named as if they originate the Camera rather than the interaction handler. The separation between these two types of events should be explicit.

  • make DragPanInteraction fire dragpanstart and dragpanend instead of movestart and moveend
  • make DragRotateInteraction fire dragrotatestart and dragrotateend instead of rotate, move, rotatestart, movestart, rotateend, moveend
  • ensure camera fires {pitch, rotate, move} x {*, *start, *end} events itself whenever appropriate
  • prevent interaction handlers with inertia from firing multiple moveend events within an individual interaction

Related to #3068 #2792

@mourner
Copy link
Member

mourner commented Oct 13, 2016

Can you clarify a bit? The two items above seem unrelated to the issue title — which events would you consider "interaction handler" and which "camera mutation"?

@lucaswoj
Copy link
Contributor Author

lucaswoj commented Oct 13, 2016

I would consider all the above events to represent "camera mutations" not "interaction handler" events. Those events should be fired by Camera exclusively.

  • BoxZoomInteraction fires boxzoomstart and boxzoomend events. 👍
  • Camera fires movestart and moveend 👍
  • DragPanInteraction also fires movestart and moveend 🙅‍♂️ It should fire events called dragpanstart and dragpanend

I updated the original ticket to be more explicit about next actions.

@mourner
Copy link
Member

mourner commented Oct 14, 2016

Agreed, thanks for clearing this up.

@pke
Copy link

pke commented Feb 16, 2017

Is this being worked on? Having a list update while pinch zooming is in progress is really slow, despite using the moveend event.

@mollymerp
Copy link
Contributor

@pke adding this to my list of eventing chores here #4253 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants